Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build audio with VS2022 #3878

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Build audio with VS2022 #3878

merged 1 commit into from
Feb 7, 2025

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Feb 6, 2025

This also clean up lots of unused files. Windows CUDA build failures are pre-existing, and I think it comes from pytorch/pytorch#144707

Copy link

pytorch-bot bot commented Feb 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3878

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 5 Pending, 6 Unrelated Failures

As of commit 7155d9d with merge base 2709b65 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn requested a review from atalman February 7, 2025 00:09
@huydhn huydhn marked this pull request as ready for review February 7, 2025 00:09
@huydhn huydhn requested a review from a team as a code owner February 7, 2025 00:09
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huydhn huydhn merged commit f084f34 into pytorch:main Feb 7, 2025
43 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants