Remove scipy torchcodec hack #4093
Closed
+0
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4093
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 PendingAs of commit eebb69f with merge base 799d288 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
samanklesaria
force-pushed
the
no_scipy_hack
branch
from
dae0273 to
0b430dd
Compare
pearu
force-pushed
the
alt-cpu-test-workflow
branch
from
b648cdf to
84d2a99
Compare
|
Now part of #4092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we found that the pytorch CI infrastructure made installing ffmpeg beyond version 4 impossible. And this version was buggy, which was making our tests fail. We hacked around the issue by making scipy pretend it was torchcodec. But the integration tests require reading flac files, which aren't supported by scipy. Fortunately, @pearu's miniconda approach to CI seems like it's been able to install more recent ffmpeg versions. So maybe we can do the same thing with the linux test CI!