-
Notifications
You must be signed in to change notification settings - Fork 723
Revise docs building CI workflow #4095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4095
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pearu .
I was hoping we could do something much simpler than what torchcodec does: torchcodec builds a wheel separately on the build
job, and then installs that wheel separately on the build-docs
jobs and builds the docs from there.
This is needed due to specific requirements of torchcodec, but for torchaudio we should be able to do something much simpler: we should be able to just install torchcodec/torch from nightlyies and then build torchaudio and the docs from source on the GH's linux.4xlarge.nvidia.gpu (i.e. one single job instead of 2).
Let's try this simpler approach first? If really that doesn't work, then the current workflow is probably OK, but it should be simplified greatly as a lot of the existing checks are for torchcodec only. I left comments to that effect - but please let's try the simpler approach first. Thanks!
3cb6bb4
to
d7628f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
Use v4.3.0 download-artifact
Temporarily switch to linux.g5.4xlarge.nvidia.gpu
a190610
to
417938a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you!
As in title.
Alternative to #4090
PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.