Skip to content

Conversation

pearu
Copy link
Collaborator

@pearu pearu commented Sep 8, 2025

As in title.

Alternative to #4090

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

Copy link

pytorch-bot bot commented Sep 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4095

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Sep 8, 2025
@pearu pearu added this to the 2.9 milestone Sep 8, 2025
@pearu pearu changed the title Replace build_docs workflow with docs workflow (copied from torchvision) Replace build_docs workflow with docs workflow (copied from torchcodec) Sep 8, 2025
@pearu pearu marked this pull request as ready for review September 8, 2025 20:11
@pearu pearu requested a review from a team as a code owner September 8, 2025 20:11
Copy link
Collaborator

@samanklesaria samanklesaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pearu .

I was hoping we could do something much simpler than what torchcodec does: torchcodec builds a wheel separately on the build job, and then installs that wheel separately on the build-docs jobs and builds the docs from there.

This is needed due to specific requirements of torchcodec, but for torchaudio we should be able to do something much simpler: we should be able to just install torchcodec/torch from nightlyies and then build torchaudio and the docs from source on the GH's linux.4xlarge.nvidia.gpu (i.e. one single job instead of 2).

Let's try this simpler approach first? If really that doesn't work, then the current workflow is probably OK, but it should be simplified greatly as a lot of the existing checks are for torchcodec only. I left comments to that effect - but please let's try the simpler approach first. Thanks!

@pearu pearu force-pushed the pearu/add-docs-workflow branch from 3cb6bb4 to d7628f1 Compare September 9, 2025 10:36
Copy link
Collaborator

@samanklesaria samanklesaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@pearu pearu marked this pull request as draft September 9, 2025 15:42
@pearu pearu force-pushed the pearu/add-docs-workflow branch from a190610 to 417938a Compare September 10, 2025 07:25
@pearu pearu marked this pull request as ready for review September 10, 2025 08:29
@pearu pearu changed the title Replace build_docs workflow with docs workflow (copied from torchcodec) Revise docs building CI workflow Sep 10, 2025
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@NicolasHug NicolasHug enabled auto-merge (squash) September 10, 2025 10:34
@NicolasHug NicolasHug merged commit 0639492 into pytorch:main Sep 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants