Skip to content

Add test when there are no segments #12687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/0.7
Choose a base branch
from

Conversation

pytorchbot
Copy link
Collaborator

Summary:
The deprecation warning should only appear when there are values inside the constant_buffer and nothing inside the constant_segment.

Even when there are no constants in the program, we expect to have one 'segment' storing the placeholder for non-constants.

Fix failing jobs caused by error logging from #12295
Test failures: https://hud.pytorch.org/pr/pytorch/executorch/12631#46239138027

Arm test is using a recently-generated PTE, however hitting the deprecation warning because the pte has no constants.

Differential Revision: D78568839

Differential Revision: D78568839

Pull Request resolved: #12646

(cherry picked from commit 4d7f9ca)
Copy link

pytorch-bot bot commented Jul 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12687

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs

As of commit 78e62aa with merge base de24489 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants