refactor diloco test #232
Merged
refactor diloco test #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2025
Merged
facebook-github-bot
added
the
CLA Signed
tushar00jain
requested review from
d4l3k and
H-Huang
and removed request for
d4l3k
d4l3k
approved these changes
Jul 15, 2025
torchft/diloco_trainer.py
Outdated
| if self.manager.current_step() >= 4: | ||
| break | ||
|
|
||
| return all_state_dicts |
There was a problem hiding this comment.
Not directly related to this PR but wonder if we should just add a main check and use this for manual testing
There was a problem hiding this comment.
what do you mean by main check? :)
torchft/diloco_trainer.py
Outdated
| @@ -0,0 +1,310 @@ | |||
| import copy | |||
There was a problem hiding this comment.
Does this makes sense under torchft/? Should we add an underscore to indicate it's internal or move it under some testing dir or something?
Just don't want folks getting confused and importing this directly for whatever reason
There was a problem hiding this comment.
moved it to test folder. will start putting everything test related there
H-Huang
approved these changes
Jul 15, 2025
tushar00jain
force-pushed
the
pr232
branch
2 times, most recently
from
0ce2173 to
56893f8
Compare
Summary: - move the training loop to a separate file - convert it into a class so that methods can be overridden without having to duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Stack created with Sapling. Best reviewed with ReviewStack.