Skip to content

Conversation

@user27182
Copy link
Contributor

@user27182 user27182 commented Aug 27, 2025

Add --doc_mode for testing documentation images. This effectively moves most of the documentation tests from pyvista to pytest-pyvista.

Code is adapted from https://github.com/pyvista/pyvista/blob/main/tests/doc/tst_doc_build.py

The functionally of the tests is largely the same as the current PyVista tests except for how flaky tests are handled. Instead of having a separate flaky_tests dir, subdirectories inside the cache image dir itself are allowed, and you just place the multiple images there instead

@github-actions github-actions bot added the enhancement New feature or request label Aug 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 99.09502% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.29%. Comparing base (5641141) to head (e6cb258).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pytest_pyvista/doc_mode.py 98.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   96.07%   97.29%   +1.21%     
==========================================
  Files           2        3       +1     
  Lines         306      518     +212     
  Branches       46       74      +28     
==========================================
+ Hits          294      504     +210     
  Misses          5        5              
- Partials        7        9       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@user27182 user27182 marked this pull request as ready for review August 28, 2025 23:44
@user27182
Copy link
Contributor Author

This is ready for review. It was also tested downstream and passes CI: pyvista/pyvista#7878

@user27182
Copy link
Contributor Author

Codecov Report

❌ Patch coverage is 6.77966% with 220 lines in your changes missing coverage. Please review. ✅ Project coverage is 17.07%. Comparing base (94813c8) to head (298011c).

Files with missing lines Patch % Lines
pytest_pyvista/doc_mode.py 0.00% 198 Missing ⚠️
pytest_pyvista/pytest_pyvista.py 42.10% 20 Missing and 2 partials ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

Coverage was something like this before #196 was merged:

❌ Patch coverage is 99.15% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.66%. Comparing base (114b35a94813c8) to head (aa39b4e329acdf).

@user27182
Copy link
Contributor Author

user27182 commented Aug 31, 2025

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, otherwise LGTM.

@user27182 user27182 merged commit a9a67fa into main Sep 4, 2025
9 checks passed
@user27182 user27182 deleted the feat/doc branch September 4, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants