-
Notifications
You must be signed in to change notification settings - Fork 6
Add --doc_mode config option for testing documentation images
#198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 96.07% 97.29% +1.21%
==========================================
Files 2 3 +1
Lines 306 518 +212
Branches 46 74 +28
==========================================
+ Hits 294 504 +210
Misses 5 5
- Partials 7 9 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is ready for review. It was also tested downstream and passes CI: pyvista/pyvista#7878 |
Coverage was something like this before #196 was merged: ❌ Patch coverage is 99.15% with 2 lines in your changes missing coverage. Please review. |
|
@akaszynski Downstream doc build tests are green again: |
akaszynski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks, otherwise LGTM.
Co-authored-by: Alex Kaszynski <[email protected]>
Add
--doc_modefor testing documentation images. This effectively moves most of the documentation tests frompyvistatopytest-pyvista.Code is adapted from https://github.com/pyvista/pyvista/blob/main/tests/doc/tst_doc_build.py
The functionally of the tests is largely the same as the current PyVista tests except for how flaky tests are handled. Instead of having a separate flaky_tests dir, subdirectories inside the cache image dir itself are allowed, and you just place the multiple images there instead