-
Notifications
You must be signed in to change notification settings - Fork 27
Validation custom #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
etokareva
wants to merge
18
commits into
master
Choose a base branch
from
validation-custom
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Validation custom #447
Changes from 10 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4796fb1
Init custom validation
etokareva d6781d0
custom validation
etokareva ef3866d
custom validation example
etokareva 592ada6
clean up code style
etokareva 361cbcf
add spaces
etokareva 60b5c49
use livr register rule method
etokareva 929f8eb
quotes
etokareva 71e4f90
rename createLivrValidator to createValidator
etokareva b762c92
change version of grid
etokareva 19137ed
Merge branch 'master' of https://github.com/qgrid/ng2 into validation…
etokareva 9f966e2
remove unnecessary empty line
etokareva f700b8f
rename custom validation binding name
etokareva bdee661
add function type to test input
etokareva 5458365
validator fetch
etokareva 752afb1
validator fetch
etokareva b926627
Merge branches 'master' and 'validation-custom' of https://github.com…
etokareva f2c479a
Merge branch 'master' of https://github.com/qgrid/ng2 into validation…
etokareva c124d28
version updates
etokareva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,4 +93,4 @@ | |
| "xlsx": "^0.14.3", | ||
| "ng2-qgrid": "*" | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| export declare interface Validator { | ||
| validate(value: any): boolean; | ||
| getErrors(): Array<string>; | ||
| } | ||
|
|
||
etokareva marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| export declare interface ValidatorBuilder { | ||
| validator: Validator; | ||
| hasCommonRules: boolean; | ||
| hasCustomRules: boolean; | ||
| registerRules(rules: any, key: string): void; | ||
| hasRules(): boolean; | ||
| } | ||
|
|
||
| export declare function createValidator(rules: any): Validator; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import * as LIVR from 'livr'; | ||
|
|
||
| export const { Validator: LivrValidator } = LIVR; | ||
|
|
||
| export function createValidator(rules) { | ||
| return new LivrValidator(rules); | ||
| } | ||
|
|
||
| export class ValidatorBuilder { | ||
| constructor(rules, key) { | ||
| this.validator = null; | ||
| this.hasCommonRules = false; | ||
| this.hasCustomRules = false; | ||
|
|
||
| this.registerRules(rules, key); | ||
| } | ||
|
|
||
| registerRules(srcRules, key) { | ||
| const rules = []; | ||
| const keyRules = srcRules.filter(r => r.key === key); | ||
| keyRules.forEach(rule => { | ||
| for (let name of Object.keys(rule)) { | ||
| if (name === 'custom_validation') { | ||
| this.customRule = {[key]: rule[name]}; | ||
| this.hasCustomRules = true; | ||
| } | ||
| if (!['for', 'key'].includes(name)) { | ||
| rules.push({ | ||
| [name]: rule[name] | ||
| }); | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| this.hasCommonRules = rules.length > 0; | ||
| const livrRules = this.hasCommonRules ? {[key]: rules} : {}; | ||
| this.validator = new LivrValidator(livrRules); | ||
| if (this.hasCustomRules) { | ||
| this.validator.registerRules({ | ||
| custom_validation:() => this.customRule[key] | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| get hasRules() { | ||
| return this.hasCommonRules || this.hasCustomRules; | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.