Added dynamic row resize indicator #589
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified code - Fixed indicator not sticking to the bottom - Added code to remove all indicators when leaving table
klumba12
reviewed
Apr 5, 2022
| q-grid-resize-selector="parent" | ||
| q-grid-resize-path="rows" | ||
| [q-grid-can-resize]="$view.row.resize.canExecute"> | ||
| <mat-icon class="q-grid-icon q-grid-row-resize-indicator" style="display: none;">unfold_more</mat-icon> |
Collaborator
There was a problem hiding this comment.
please remove explicit style="display: none"
|
|
||
| observe(model.highlightChanged) | ||
| .subscribe(e => { | ||
| if (e.changes.cell?.oldValue && e.changes.cell?.newValue && e.changes.cell.oldValue.rowIndex !== e.changes.cell.newValue.rowIndex){ |
packages/qgrid-styles/focus.scss
Outdated
| } | ||
|
|
||
| .q-grid-row-size-handler { | ||
| .q-grid-row-resize-indicator { |
Collaborator
There was a problem hiding this comment.
q-grid-row-size-indicator
- Fixed bug for row highlight events - Fixed bug in layer service whereby all layers would be destroyed on container clear
klumba12
reviewed
Apr 11, 2022
| } | ||
|
|
||
| const noopLayer = new Layer(() => this.layers.delete(name)); | ||
|
|
| @Component({ | ||
| selector: 'q-grid-row', | ||
| template: '<ng-content></ng-content>', | ||
| template: `<ng-container></ng-container>`, |
| this.oneRow = new Command({ | ||
| source: 'highlight.oneRow', | ||
| canExecute: () => !this.isRendering, | ||
| execute: (row, state) => { |
Collaborator
There was a problem hiding this comment.
it should not be a state argument, this command just should highlight a row, not to unhighlight
- Formatting corrections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.