-
Notifications
You must be signed in to change notification settings - Fork 27
Added dynamic row resize indicator #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FinalButterfly
wants to merge
5
commits into
qgrid:master
Choose a base branch
from
FinalButterfly:feature/row-resize-indicator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5e9b93f
Added dynamic row resize indicator
FinalButterfly 75e7e0b
Re-worked the code to use row style API instead of creating & deletin…
FinalButterfly d22f0c5
Row resize indicator, third pass
FinalButterfly 52b0adc
Row resize indicator, fourth pass
FinalButterfly b5f34e0
Row size indicator, fifth pass
FinalButterfly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,7 @@ export class RowComponent implements OnChanges, OnInit { | |
| } | ||
|
|
||
| ngOnInit() { | ||
| const { model, observe } = this.plugin; | ||
| const { model, observe, table } = this.plugin; | ||
|
|
||
| if (this.behavior.indexOf('expandOnShortcut') >= 0) { | ||
| observe(model.keyboardChanged) | ||
|
|
@@ -90,6 +90,29 @@ export class RowComponent implements OnChanges, OnInit { | |
| }); | ||
| } | ||
| } | ||
|
|
||
| observe(model.highlightChanged) | ||
| .subscribe(e => { | ||
| if (e.changes.cell?.oldValue && e.changes.cell?.newValue && e.changes.cell.oldValue.rowIndex !== e.changes.cell.newValue.rowIndex){ | ||
|
||
| const previousRow = table.body.row(e.changes.cell.oldValue.rowIndex); | ||
| const newRow = table.body.row(e.changes.cell.newValue.rowIndex); | ||
|
|
||
| previousRow.removeClass('q-grid-row-size-handler'); | ||
| newRow.addClass('q-grid-row-size-handler'); | ||
| } | ||
| }); | ||
|
|
||
| observe(model.mouseChanged) | ||
| .subscribe(e => { | ||
| if(e.changes.status?.newValue === 'leave' && e.state.status === 'leave') { | ||
| const indicators = document.getElementsByClassName('q-grid-row-size-handler') as HTMLCollectionOf<HTMLElement>; | ||
| if(indicators.length > 0) { | ||
| for(let i = 0; i < indicators.length; i++) { | ||
| indicators[i].classList.remove('q-grid-row-size-handler'); | ||
| } | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| ngOnChanges() { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,15 @@ td.q-grid-focused { | |
| } | ||
| } | ||
|
|
||
| .q-grid-row-size-handler { | ||
| .q-grid-row-resize-indicator { | ||
|
||
| display: block!important; | ||
| margin-top: 16px; | ||
| position: absolute; | ||
| bottom: 0; | ||
| } | ||
| } | ||
|
|
||
| .q-grid-view.q-grid-active { | ||
| td.q-grid-focused { | ||
| outline-color: $blue-outline025; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove explicit
style="display: none"