Update gf2.MultiplyPolyByConstantMod to support QGF dtype #1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ualtran into gf2_polynomials
mpharrigan
reviewed
Feb 3, 2025
| @@ -144,7 +144,7 @@ | |||
| }, | |||
| { | |||
| "cell_type": "markdown", | |||
| "id": "b26814e0", | |||
| "id": "94ab395f", | |||
There was a problem hiding this comment.
why do these always get overwritten? they should generally be maintained. The autogenerate-bloqs-notebooks script should maintain these
mpharrigan
approved these changes
Feb 3, 2025
tanujkhattar
reviewed
Feb 3, 2025
qualtran/_infra/data_types.py
Outdated
| @@ -899,6 +904,7 @@ class QGF(QDType): | |||
|
|
|||
| characteristic: SymbolicInt | |||
| degree: SymbolicInt | |||
| galois_field: Optional['galois.FieldArrayMeta'] = None | |||
There was a problem hiding this comment.
This type is not hashable, as discussed offline please consider updating the class attributes so you only store hashable types and construct the corresponding galois field object by passing in the values to the constructor.
There was a problem hiding this comment.
@NoureldinYosri Can you please confirm if this was addressed ?
There was a problem hiding this comment.
QGF was made hashable ... MultiplyPolyByConstantMod is hashable because I overload its hash method ... or do you want to do the same for MultiplyPolyByConstantMod?
This was referenced Feb 15, 2025
This was referenced Mar 5, 2025
NoureldinYosri
added a commit
that referenced
this pull request
Mar 31, 2025
This is the final PR in the series #1554, #1533, and #1516. These PRs implemented the GF($2^n$) multiplication construction from https://arxiv.org/abs/1910.02849v2 which has a toffoli complexity of $n^{\log_2{3}}$
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiplyPolyByConstantModtoGF2MultiplyByConstantModQGFinstead of an array of qubitsQGFto include an optional field for the galois field