Skip to content

Port to matrix-rust-sdk-crypto #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Port to matrix-rust-sdk-crypto #820

wants to merge 3 commits into from

Conversation

TobiasFella
Copy link
Member

@TobiasFella TobiasFella commented Oct 26, 2024 •
edited
Loading

TODO:

  • Test "all" possible verification scenarios
  • Retry decrypting events once a new key has arrived
  • Store new keys to backup
  • Load keys from backup
  • migration from current database to rust-sdk database
  • Clean up code, TODOs
  • Check against NeoChat for missing functionality

@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 3 times, most recently from 2bf6831 to f01f524 Compare November 4, 2024 21:12
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 3 times, most recently from 0796120 to c76e066 Compare November 8, 2024 21:21
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 4 times, most recently from a07274a to 8c33951 Compare November 16, 2024 12:31
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 2 times, most recently from 453f6cc to 8e4ad29 Compare November 28, 2024 21:28
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 14 times, most recently from 214ccab to d3814ed Compare December 14, 2024 12:06
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 2 times, most recently from 0c7f343 to b300831 Compare December 14, 2024 12:33
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 2 times, most recently from 0f8fc8b to fea61b9 Compare December 29, 2024 21:38
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 3 times, most recently from 677e82d to 993e4c9 Compare January 25, 2025 16:15
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 2 times, most recently from 830c221 to face992 Compare April 3, 2025 19:22
KitsuneRal
KitsuneRal reviewed Apr 4, 2025
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through most of the stuff, a few superficial comments and suggestions below. Overall LGTM so far.

.github/workflows/ci.yml Outdated
run: cmake --build build --target update-api

- name: Build and install libQuotient
shell: pwsh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document why :)

quotest/quotest.cpp Outdated
clog << "Connected, server: " << c->homeserver().toDisplayString().toStdString() << '\n'
<< "Access token: " << c->accessToken().toStdString() << endl;

// We can't do this, as the crypto machine is already initialized and explodes when this is run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this piece emulates is a client connecting to a homeserver, getting a token, immediately disconnecting, and connecting again with the obtained token. It would probably help to deconstruct the original connection before newC->assumeIdentity() is called? In that case the crypto machine in the original connection object will be dismantled before the one in the new connection is initialised.

KitsuneRal
KitsuneRal reviewed Apr 12, 2025
View reviewed changes
@KitsuneRal KitsuneRal mentioned this pull request May 2, 2025
Merged
@KitsuneRal KitsuneRal mentioned this pull request Jun 24, 2025
Open
@TobiasFella
Copy link
Member Author

  • Updated rust dependencies
  • Added migration for account and megolm sessions 🥳 (I don't think we can migrate olm sessions; i also don't think we need to. I'll try to figure that out next week.)

@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch from 04cf798 to d241931 Compare July 14, 2025 21:15
@TobiasFella
Copy link
Member Author

  • Turns out we do need to migrate the olm sessions; i also figured out how to do so. It's already implemented cleaner than the megolm migration, but also still needs error handling
  • Next: migrating CS keys (and backup version, i think)
  • Figure out whether migrating all olm and megolm sessions is a good idea, since i guess there might be many of them

@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch from 4743df3 to ff44fe5 Compare July 19, 2025 12:26
@foresto foresto mentioned this pull request Jul 25, 2025
Open
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 3 times, most recently from 2d0d8c7 to fd5bf09 Compare August 31, 2025 19:22
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 3 times, most recently from 6b123d0 to 31a70c3 Compare September 8, 2025 18:10
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch 6 times, most recently from 428d639 to c43999c Compare September 25, 2025 14:54
@TobiasFella TobiasFella force-pushed the tobias/rust-sdk-crypto branch from c43999c to dd68852 Compare September 25, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal left review comments

Assignees
No one assigned
Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: In work
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiasFella @KitsuneRal