Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded list of resource types from cli. #8286

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

add comment

916e4eb
Select commit
Loading
Failed to load commit list.
Open

remove hardcoded list of resource types from cli. #8286

add comment
916e4eb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 7, 2025 in 0s

59.85% (-0.10%) compared to 8e6d5ff

View this Pull Request on Codecov

59.85% (-0.10%) compared to 8e6d5ff

Details

Codecov Report

Attention: Patch coverage is 66.95652% with 38 lines in your changes missing coverage. Please review.

Project coverage is 59.85%. Comparing base (8e6d5ff) to head (916e4eb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cli/clients/management.go 56.25% 14 Missing and 7 partials ⚠️
pkg/cli/cmd/resource/delete/delete.go 41.66% 7 Missing ⚠️
pkg/cli/clivalidation.go 80.00% 3 Missing and 1 partial ⚠️
pkg/cli/cmd/resource/create/create.go 50.00% 2 Missing and 1 partial ⚠️
pkg/cli/cmd/resource/list/list.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8286      +/-   ##
==========================================
- Coverage   59.94%   59.85%   -0.10%     
==========================================
  Files         596      596              
  Lines       40432    40454      +22     
==========================================
- Hits        24238    24213      -25     
- Misses      14367    14416      +49     
+ Partials     1827     1825       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov