Skip to content

Image inference #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Apr 22, 2025
Merged

Image inference #217

merged 17 commits into from
Apr 22, 2025

Conversation

chocolatkey
Copy link
Member

@chocolatkey chocolatkey commented Apr 17, 2025

Closes #176

  • Includes the streaming working of Implement remote streaming of publications #211 (no changes, no need to re-review)
  • Add a helper to transform fetchers and resources into interfaces compatible with Go's fs.FS and fs.File
  • Add support for hash property in links, with a list of recognized algorithms and utility functions
  • Add --inspect-images and --hash flags to rwp manifest utility to enable inference of additional image metadata

@chocolatkey chocolatkey marked this pull request as ready for review April 20, 2025 23:39
@chocolatkey chocolatkey requested review from mickael-menu and Copilot and removed request for Copilot April 20, 2025 23:39
Copilot

This comment was marked as resolved.

@chocolatkey
Copy link
Member Author

@mickael-menu regarding the dependency issue, as per the meeting I'm going to deal with this after the merge, as the perceptual hashing package (which is not maintained) itself depends on that image resizing dependency. Furthermore, we may want to move the image inspection code out of the go-toolkit into the readium-cli

Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes

@chocolatkey chocolatkey merged commit 8b61f70 into develop Apr 22, 2025
3 of 4 checks passed
@chocolatkey chocolatkey deleted the image-inference branch April 22, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extracting additional information from images
2 participants