[#52] Add initialStorylineCount constructor param#53
Merged
realproject7 merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
Skip past existing PL-1..PL-8 symbols on shared MCV2_Bond by allowing the factory to start its counter at a configurable offset. DeployBase passes 8; all other callers pass 0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Minimal, correct change — constructor param sets the counter offset, DeployBase passes 8 to skip existing symbols, all other callers pass 0. CI green (45/45 tests). Approved.
project7-interns
approved these changes
Mar 20, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #52. It adds the constructor seed for storylineCount, passes 8 in the Base deploy script, preserves 0 for fresh deployments/tests, and updates all constructor call sites cleanly.
Findings
- None.
Decision
Approved. The counter initialization lines up with createStoryline() pre-increment logic, so a deployment seeded with 8 will correctly start creating PL-9 and avoid the existing symbol collision on the shared bond.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialStorylineCountconstructor param toStoryFactoryso the counter can skip past symbols already registered on the shared MCV2_Bond (PL-1 through PL-8)DeployBase.s.solpasses8; all other deploy scripts and tests pass0Fixes #52
Test plan
forge build— compiles cleanlyforge test -vv— 45/45 pass🤖 Generated with Claude Code