Skip to content

[#52] Add initialStorylineCount constructor param #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realproject7 merged 1 commit into from
Mar 20, 2026
Merged

[#52] Add initialStorylineCount constructor param #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion script/DeployBase.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ contract DeployBase is Script {
uint256 deployerKey = vm.envUint("DEPLOYER_PRIVATE_KEY");
vm.startBroadcast(deployerKey);

StoryFactory factory = new StoryFactory(MCV2_BOND, PL_TEST, MAX_SUPPLY, stepRanges, stepPrices);
StoryFactory factory = new StoryFactory(MCV2_BOND, PL_TEST, MAX_SUPPLY, stepRanges, stepPrices, 8);

vm.stopBroadcast();

Expand Down
2 changes: 1 addition & 1 deletion script/DeployBaseSepolia.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ contract DeployBaseSepolia is Script {
uint256 deployerKey = vm.envUint("DEPLOYER_PRIVATE_KEY");
vm.startBroadcast(deployerKey);

StoryFactory factory = new StoryFactory(MCV2_BOND, PLOT_TOKEN, MAX_SUPPLY, stepRanges, stepPrices);
StoryFactory factory = new StoryFactory(MCV2_BOND, PLOT_TOKEN, MAX_SUPPLY, stepRanges, stepPrices, 0);

vm.stopBroadcast();

Expand Down
6 changes: 3 additions & 3 deletions script/E2ETestReverts.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ contract E2ETestReverts is Script {
p1[0] = 1e15;

// H1: Zero bond address
try new StoryFactory(address(0), address(1), 1e18, r1, p1) {
try new StoryFactory(address(0), address(1), 1e18, r1, p1, 0) {
revert("H1: should have reverted");
} catch Error(string memory reason) {
require(keccak256(bytes(reason)) == keccak256("Zero bond address"), "H1: wrong revert reason");
Expand All @@ -231,7 +231,7 @@ contract E2ETestReverts is Script {
}

// H2: Zero token address
try new StoryFactory(address(1), address(0), 1e18, r1, p1) {
try new StoryFactory(address(1), address(0), 1e18, r1, p1, 0) {
revert("H2: should have reverted");
} catch Error(string memory reason) {
require(keccak256(bytes(reason)) == keccak256("Zero token address"), "H2: wrong revert reason");
Expand All @@ -246,7 +246,7 @@ contract E2ETestReverts is Script {
bigR[i] = uint128(i + 1);
bigP[i] = uint128(i + 1);
}
try new StoryFactory(address(1), address(1), 1e18, bigR, bigP) {
try new StoryFactory(address(1), address(1), 1e18, bigR, bigP, 0) {
revert("H3: should have reverted");
} catch Error(string memory reason) {
require(keccak256(bytes(reason)) == keccak256("Too many steps"), "H3: wrong revert reason");
Expand Down
4 changes: 3 additions & 1 deletion src/StoryFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ contract StoryFactory {
address _plotToken,
uint128 _maxSupply,
uint128[] memory _stepRanges,
uint128[] memory _stepPrices
uint128[] memory _stepPrices,
uint256 _initialStorylineCount
) {
require(_bond != address(0), "Zero bond address");
require(_plotToken != address(0), "Zero token address");
Expand All @@ -102,6 +103,7 @@ contract StoryFactory {
owner = msg.sender;
stepRanges = _stepRanges;
stepPrices = _stepPrices;
storylineCount = _initialStorylineCount;
}

// -----------------------------------------------------------------------
Expand Down
8 changes: 4 additions & 4 deletions test/StoryFactory.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ contract StoryFactoryTest is Test {
prices[0] = 1e15;
prices[1] = 1e18;

factory = new StoryFactory(address(bond), address(plot), 1_000_000e18, ranges, prices);
factory = new StoryFactory(address(bond), address(plot), 1_000_000e18, ranges, prices, 0);
}

// ===================================================================
Expand Down Expand Up @@ -408,7 +408,7 @@ contract StoryFactoryTest is Test {
prices[0] = 1e15;

vm.expectRevert("Zero bond address");
new StoryFactory(address(0), address(plot), 1e18, ranges, prices);
new StoryFactory(address(0), address(plot), 1e18, ranges, prices, 0);
}

function test_constructor_revert_zeroToken() public {
Expand All @@ -418,7 +418,7 @@ contract StoryFactoryTest is Test {
prices[0] = 1e15;

vm.expectRevert("Zero token address");
new StoryFactory(address(bond), address(0), 1e18, ranges, prices);
new StoryFactory(address(bond), address(0), 1e18, ranges, prices, 0);
}

function test_constructor_revert_tooManySteps() public {
Expand All @@ -430,7 +430,7 @@ contract StoryFactoryTest is Test {
}

vm.expectRevert("Too many steps");
new StoryFactory(address(bond), address(plot), 1e18, ranges, prices);
new StoryFactory(address(bond), address(plot), 1e18, ranges, prices, 0);
}

// ===================================================================
Expand Down