[rhoai-2.25] RHAIENG-6127: remove tf2onnx from ROCm TensorFlow images on rhoai-2.25 - #2456
[rhoai-2.25] RHAIENG-6127: remove tf2onnx from ROCm TensorFlow images on rhoai-2.25#2456jiridanek wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
💤 Files with no reviewable changes (5)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe ROCm TensorFlow Python 3.12 configurations remove ChangesROCm TensorFlow dependency cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jiridanek
changed the title
bd8ad7b to
6c93482
Compare
|
/build-konflux |
CI status [antigravity]Run: Build Notebooks (push) #30798492352 — 2/2 complete · 2 skipped Workflow completed with skipped jobs. |
|
Done. Summary: RebaseRebased
Conflict resolution kept Force-pushPushed to
Konflux triggerPosted The rebased commit is much smaller now (7 files, +8/−44) because lockfiles were regenerated cleanly against the current base instead of carrying the old broad upgrades. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.toml`:
- Line 2: Update the pylock regeneration command comment to include an explicit
override input for the project’s protobuf override, using the existing override
file or configuration that enforces protobuf==6.31.1. Ensure regenerated
dependencies retain protobuf version 6.31.1.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 62fbabb4-87db-4c72-978c-fef692466b16
📒 Files selected for processing (7)
jupyter/rocm/tensorflow/ubi9-python-3.12/pylock.tomljupyter/rocm/tensorflow/ubi9-python-3.12/pyproject.tomljupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynbruntimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocmruntimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocmruntimes/rocm-tensorflow/ubi9-python-3.12/pylock.tomlruntimes/rocm-tensorflow/ubi9-python-3.12/pyproject.toml
💤 Files with no reviewable changes (4)
- runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.rocm
- runtimes/rocm-tensorflow/ubi9-python-3.12/Dockerfile.konflux.rocm
- jupyter/rocm/tensorflow/ubi9-python-3.12/test/test_notebook.ipynb
- runtimes/rocm-tensorflow/ubi9-python-3.12/pyproject.toml
|
/build-konflux |
CI status [antigravity]Run: Build Notebooks (pr) #30798495172 — 3/3 complete · 1 passed · 2 cancelled Failures so far
Likely root causes
Suggested next steps
|
|
/test odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request |
|
@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request |
|
@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
CI status [antigravity]Run: Build Notebooks (pr) #30799009588 — 3/3 passed All matrix jobs completed successfully. |
📋 Review SummaryThis pull request correctly backports the removal of the abandoned 🔍 General Feedback
I did not post any inline review comments as no real issues or concrete improvements were found in the changed files. |
Backport RHAIENG-3019 / opendatahub-io#2987 to rhoai-2.25: - Drop tf2onnx from jupyter and runtime pyproject.toml - Keep jupyter protobuf override at 6.31.1 (kfp vs tensorflow-rocm; RHAIENG-4324) - Remove runtime protobuf override (resolves to 5.29.6 without kfp) - Remove tf2onnx test/import from test_notebook.ipynb (builds on #2455) - Drop runtime monkey_patch_protobuf COPY from Dockerfiles - Regenerate pylock.toml for both images Co-authored-by: Cursor <cursoragent@cursor.com>
…code Regenerate pylock.toml comment headers via ci/generate_code.sh so they match sync-python-lockfiles.sh output expected by CI (no pylocks_generator extras). Co-authored-by: Cursor <cursoragent@cursor.com>
f5f399f to
9205e2e
Compare
|
/retest odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request |
|
@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request odh-pipeline-runtime-pytorch-llmcompressor-cuda-py312-on-pull-request |
|
@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/build-konflux |
CI status [antigravity]Run: Build Notebooks (push) #30800968193 — 2/2 complete · 2 skipped Workflow completed with skipped jobs. |
CI status [antigravity]Run: Build Notebooks (pr) #30800970549 — 3/3 passed All matrix jobs completed successfully. |
|
/test odh-pipeline-runtime-tensorflow-rocm-py312-on-pull-request |
|
@jiridanek: No presubmit jobs available for red-hat-data-services/notebooks@rhoai-2.25 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
Description
Backport RHAIENG-3019 / opendatahub-io#2987 to
rhoai-2.25— remove abandonedtf2onnxfrom ROCm TensorFlow workbench and runtime images.Follows merged #2455 (papermill test fixes); this PR completes dependency removal.
Jira: RHAIENG-6127
Changes
jupyter/rocm/tensorflow/.../pyproject.tomltf2onnx; keepprotobuf==6.31.1(tensorflow-rocm vs kfp; RHAIENG-4324)runtimes/rocm-tensorflow/.../pyproject.tomltf2onnx+ protobuf override → resolves to 5.29.6test_notebook.ipynbimport tf2onnxandtest_tf2onnx_conversionentirelymonkey_patch_protobuf_6x.pyCOPY (protobuf 5.x)pylock.tomlWorkbench Dockerfiles still copy
monkey_patch_protobuf_6x.py(needed for protobuf 6.31.1 + tensorflow-rocm).How Has This Been Tested?
rocm-jupyter-tensorflow-ubi9-python-3.12Build Notebooks matrix jobrocm-runtime-tensorflow-ubi9-python-3.12buildSelf checklist (all need to be checked):
make test(gmakeon macOS) before asking for reviewDockerfile.konfluxfiles should be done inodh/notebooksand automatically synced torhds/notebooks. For Konflux-specific changes, modifyDockerfile.konfluxfiles directly inrhds/notebooksas these require special attention in the downstream repository and flow to the upcoming RHOAI release.Merge criteria:
Made with Cursor
Summary by CodeRabbit