[Staging] Optimizing Vector Configuration to avoid missing logs #5324
Conversation
Optimized the vector configuration to avoid missing logs.
khrm
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test appstudio-e2e-tests |
| @@ -17,7 +17,8 @@ customConfig: | |||
| kubernetes_logs: | |||
| type: kubernetes_logs | |||
| rotate_wait_secs: 5 | |||
| glob_minimum_cooldown_ms: 15000 | |||
| glob_minimum_cooldown_ms: 500 | |||
There was a problem hiding this comment.
Maybe do that 1s (1000)? IMO that'll be enough to detect the new logs, without stressing the system too much. I've already heard complains of vector (not our deployment) being too resource hungry. Unless you have some data to suggest 0.5 is the value we need.
There was a problem hiding this comment.
I use this reference while setting this: vectordotdev/vector#7934 (comment)
There was a problem hiding this comment.
OK. I was thinking most short lived taskruns I've seen are taking ~3s, so setting that value to 1s will be enough to not miss logs without over stressing the system. Anyway, we can start with that lower value and monitor the resource utilization and increase the value if needed.
|
/lgtm |
openshift-merge-bot
bot
merged commit 342bba0
into
redhat-appstudio:main
Optimized the vector configuration to avoid missing logs.