Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staging] Optimizing Vector Configuration to avoid missing logs #5324

Merged
merged 1 commit into from
Jan 21, 2025
Merged

[Staging] Optimizing Vector Configuration to avoid missing logs #5324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/vector-tekton-logs-collector/development/vector-helm-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ customConfig:
kubernetes_logs:
type: kubernetes_logs
rotate_wait_secs: 5
glob_minimum_cooldown_ms: 15000
glob_minimum_cooldown_ms: 500
Copy link
Contributor

@enarha enarha Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do that 1s (1000)? IMO that'll be enough to detect the new logs, without stressing the system too much. I've already heard complains of vector (not our deployment) being too resource hungry. Unless you have some data to suggest 0.5 is the value we need.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this reference while setting this: vectordotdev/vector#7934 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I was thinking most short lived taskruns I've seen are taking ~3s, so setting that value to 1s will be enough to not miss logs without over stressing the system. Anyway, we can start with that lower value and monitor the resource utilization and increase the value if needed.

max_read_bytes: 3145728
auto_partial_merge: true
extra_label_selector: "app.kubernetes.io/managed-by in (tekton-pipelines,pipelinesascode.tekton.dev)"
internal_metrics:
Expand Down
3 changes: 2 additions & 1 deletion components/vector-tekton-logs-collector/staging/vector-helm-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ customConfig:
kubernetes_logs:
type: kubernetes_logs
rotate_wait_secs: 5
glob_minimum_cooldown_ms: 15000
glob_minimum_cooldown_ms: 500
max_read_bytes: 3145728
auto_partial_merge: true
extra_label_selector: "app.kubernetes.io/managed-by in (tekton-pipelines,pipelinesascode.tekton.dev)"
internal_metrics:
Expand Down
Loading