-
Notifications
You must be signed in to change notification settings - Fork 81
feat(extensions): add row actions to installed packages #1558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(extensions): add row actions to installed packages #1558
Conversation
Unexpected ChangesetsThe following changeset(s) reference packages that have not been changed in this PR:
Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets. Changed Packages
|
|
Thank you @debsmita1 , looks great! |
9233fc2 to
f1ecf4a
Compare
The icons currently don't have a tooltip. Only if they are disabled for any reason , the tooltip shown. |
a1f739f to
939488f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @debsmita1 , thanks for the PR. I finally got it working with some specific commit. When I use marketplace backend plugin exported from this PR with current rhidp-8301-remove-dynamic-plugins-info-plugin branch version RHDH, the marketplace plugin doesn't load any data like this


Then I tried some old commits, which worked together to test changes in this PR, here's the version I used.


It seems that the issue is with the backstage version bump in marketplace backend plugin. After the backstage version bump, the backend stops loading. (cc @teknaS47 , @christoph-jerolimov )
Here's the recording for the UI changes in this PR:
pr_1558.mp4
Things I observed:
- when hover on Edit button, the highlight effect is not a circle but a oral shape(low priority)
- clicking on
Cancelbutton on package edit page takes the user to the drawer, instead of going directly back to the installed packages table. - tooltip for action buttons only shows up when buttons are disabled, and the message seems off, it should be the permission hint instead of the button function.
enable/disabletoggle button not working correctly, when coming back to the installed packages table, the toggle button shows the old value. Will this be handled in another story?- only when I am in the list of
admin.superUsersI have permissions for action buttons. If I'm in theadmin.userslist, I have no permission to use these row action buttons. Is this expected? The following is what I see when I am only in theadmin.userslist, instead of beingadmin.superUserslist. The tooltip looks right in this case.
e62d59a to
f5605e1
Compare
| plugin, | ||
| }: { | ||
| plugin: MarketplacePlugin; | ||
| plugin: MarketplacePlugin | MarketplacePackage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naaa? Why is this needed? We had a MarketplacePackageContent before? I expect we lose a lot of type save-tyness if we say "this can be a package as well"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this Content component for both cases so I could reuse the Actions dropdown that we display in the plugin drawer content. We want to show the same dropdown for the package as well. Since it’s rendered based on permissions, I wanted to avoid duplicating that logic.
f5605e1 to
e890039
Compare
Fixed it !
Updated the tooltip to show the action function when package entity is available and the logged in user has permission to manage package config
cc @ShiranHi
It Requires backend restart after you change anything in the config. We should test this on a cluster
Yes, this is how it works as of today, you need the following permissions to manage plugin configuration else you add yourself as a super user @ShiranHi I also added the alert for package config modification
|
338e2bf to
4feffaa
Compare
105becd to
9847fac
Compare
|
Hi @debsmita1 , thanks for the updates. It's almost working perfect now except for the "disable/enable" toggle button which doesn't do anything when I click on it with permission. When I don't have the permission the tooltips are showing two kinds of messages, is this expected? pr_1558_2.mp4Also, this time I was able to use the current |
147896f to
fa0b12d
Compare
@ciiay Yes, if the package doesn't have an entity, we cannot really check if the user has permission to manage the package config as the the
|
fa0b12d to
944a9be
Compare
4710c31 to
e216877
Compare
e216877 to
9f6f02e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debsmita1 I know this PR has already been merged, but I think we should update the tooltip text to align with the design. The rest looks great, thank you! |












Hey, I just made a Pull Request!
Resolves: https://issues.redhat.com/browse/RHIDP-6810
Notes:
Uninstallaction will be worked on in a different PRScreenshots:
Screen.Recording.2025-10-01.at.10.28.33.PM.mov
Test setup:
✔️ Checklist