fix(marketplace): remove dynamic-plugins-info plugins #3366

ciiay · 2025-09-05T07:02:14Z

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

Fixes RHIDP-8301

PR acceptance criteria

Please make sure that the following steps are complete:

GitHub Actions are completed and successful
Unit Tests are updated and passing
E2E Tests are updated and passing
Documentation is updated if necessary (requirement for new features)
Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

dynamic-plugins.default.yaml

debsmita1 · 2025-09-08T15:38:42Z

dynamic-plugins.default.yaml

-                  path: marketplace
-                  title: Catalog
+              - mountPoint: application/provider
+                importName: InstallationContextProvider


Can you get rid of this mount point and handle the installed plugins context by wrapping the DynamicMarketplacePluginRouter component with a context provider (See comment section here https://issues.redhat.com/browse/RHIDP-8301)

This Context provider keeps track of plugins that are installed/updated/enabled/disabled to list them on the catalog page alert.

Please remove this

github-actions · 2025-09-09T03:06:58Z

The image is available at:

christoph-jerolimov

One change looks unnecessary to me, but maybe I'm wrong.

And can we merge this without updating the marketplace? I think it would great to remove the dynamic-plugins-info plugin when also update the marketplace that includes this feature (tab)

github-actions · 2025-09-18T21:43:58Z

The image is available at:

github-actions · 2025-09-20T04:31:15Z

The image is available at:

Signed-off-by: Yi Cai <[email protected]>

github-actions · 2025-10-12T23:57:50Z

The image is available at:

ciiay · 2025-10-13T03:53:46Z

/retest

lokanandaprabhu · 2025-10-13T06:03:11Z

On trying to disable the package, nothing happened, and on checking the network tab I can see error "Installation feature is disabled under 'extensions.installation.enabled'"

Do we need to disable the button when installation feature is disabled ??

invincibleJai · 2025-10-13T06:28:08Z

/retest

sanketpathak · 2025-10-13T06:32:00Z

Tested on the cluster, the feature seems to work except for the toggle, so I created a bug for it RHDHBUGS-2125

Screen.Recording.2025-10-10.at.8.40.59.PM.mov

Screen.Recording.2025-10-10.at.8.42.07.PM.mov

fix(e2e): stable fix for extenstions

github-actions · 2025-10-13T15:41:15Z

The image is available at:

openshift-ci · 2025-10-13T15:49:38Z

@ciiay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-tests	`02eed18`	link	true	`/test e2e-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

HusneShabbir · 2025-10-13T15:51:12Z

/retest

debsmita1 · 2025-10-13T16:09:14Z

Tested the PR locally, and it works fine

Tested on the cluster

Screen.Recording.2025-10-13.at.9.1.mp4

Screen.Recording.2025-10-13.at.9.2.mp4

debsmita1

Created this ticket to handle the installation disabled scenario https://issues.redhat.com/browse/RHDHBUGS-2126

/lgtm

HusneShabbir · 2025-10-13T16:26:13Z

/lgtm
All the tests passed on #3539, expecting a clean CI here too

openshift-ci · 2025-10-13T16:26:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, HusneShabbir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [debsmita1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

debsmita1 · 2025-10-13T16:50:58Z

Tested on the cluster, the feature seems to work except for the toggle, so I created a bug for it RHDHBUGS-2125
Screen.Recording.2025-10-10.at.8.40.59.PM.mov Screen.Recording.2025-10-10.at.8.42.07.PM.mov

@sanketpathak Could you verify this again ? I have uploaded a video in the above comment, and I didn't come across this issue

It looks like [1][2] removed the dynamic-plugins-info backend plugin and we should now call '/api/extensions/loaded-plugins' instead of '/api/dynamic-plugins-info/loaded-plugins' [1] redhat-developer/rhdh#3366 [2] https://issues.redhat.com/browse/RHIDP-8301

It looks like [1][2] removed the dynamic-plugins-info backend plugin and we should now call '/api/extensions/loaded-plugins' instead of '/api/dynamic-plugins-info/loaded-plugins' [1] redhat-developer/rhdh#3366 [2] https://issues.redhat.com/browse/RHIDP-8301 Co-authored-by: Armel Soro <[email protected]>

openshift-ci bot requested review from dzemanov and its-mitesh-kumar September 5, 2025 07:02

ciiay added the do-not-merge/hold label Sep 5, 2025

ciiay temporarily deployed to internal September 5, 2025 07:02 — with GitHub Actions Inactive

ciiay mentioned this pull request Sep 5, 2025

feat(marketplace): integrate plugins-info plugin redhat-developer/rhdh-plugins#1395

Merged

4 tasks

ciiay requested a review from debsmita1 September 5, 2025 07:31

openshift-merge-robot added the needs-rebase label Sep 5, 2025

ciiay force-pushed the rhidp-8301-remove-dynamic-plugins-info-plugin branch from 529e0cb to c43f99c Compare September 8, 2025 14:02

openshift-merge-robot removed the needs-rebase label Sep 8, 2025

ciiay temporarily deployed to internal September 8, 2025 14:02 — with GitHub Actions Inactive

debsmita1 requested changes Sep 8, 2025

View reviewed changes

ciiay force-pushed the rhidp-8301-remove-dynamic-plugins-info-plugin branch from e447674 to 5f70157 Compare September 9, 2025 01:04

dzemanov mentioned this pull request Sep 9, 2025

fix(dynamic-plugins-info): remove scalprum dep #3281

Closed

5 tasks

christoph-jerolimov requested changes Sep 10, 2025

View reviewed changes

openshift-merge-robot added the needs-rebase label Sep 13, 2025

ciiay force-pushed the rhidp-8301-remove-dynamic-plugins-info-plugin branch from 0370974 to 8242d78 Compare September 18, 2025 20:47

openshift-merge-robot removed the needs-rebase label Sep 18, 2025

ciiay temporarily deployed to internal September 18, 2025 20:47 — with GitHub Actions Inactive

openshift-merge-robot added the needs-rebase label Sep 20, 2025

ciiay temporarily deployed to internal September 20, 2025 03:04 — with GitHub Actions Inactive

ciiay force-pushed the rhidp-8301-remove-dynamic-plugins-info-plugin branch from a540e2c to fbdf0b2 Compare September 20, 2025 03:36

openshift-merge-robot removed the needs-rebase label Sep 20, 2025

ciiay temporarily deployed to internal September 20, 2025 03:36 — with GitHub Actions Inactive

ciiay force-pushed the rhidp-8301-remove-dynamic-plugins-info-plugin branch from fbdf0b2 to 88614e7 Compare September 24, 2025 18:31

ciiay temporarily deployed to internal September 24, 2025 18:31 — with GitHub Actions Inactive

ciiay temporarily deployed to internal September 24, 2025 18:33 — with GitHub Actions Inactive

ciiay temporarily deployed to internal September 24, 2025 19:02 — with GitHub Actions Inactive

updated dynamic-plugins/yarn.lock

607cf09

Signed-off-by: Yi Cai <[email protected]>

ciiay force-pushed the rhidp-8301-remove-dynamic-plugins-info-plugin branch from cb783df to 607cf09 Compare October 12, 2025 22:45

ciiay temporarily deployed to internal October 12, 2025 22:46 — with GitHub Actions Inactive

ciiay requested a review from debsmita1 October 13, 2025 03:54

HusneShabbir and others added 2 commits October 13, 2025 20:03

e2e fix

6050df3

Merge pull request #3 from HusneShabbir/pr/ciiay/3366

ca5383c

fix(e2e): stable fix for extenstions

ciiay temporarily deployed to internal October 13, 2025 14:37 — with GitHub Actions Inactive

debsmita1 approved these changes Oct 13, 2025

View reviewed changes

openshift-ci bot assigned debsmita1 Oct 13, 2025

openshift-ci bot added lgtm approved labels Oct 13, 2025

openshift-ci bot assigned HusneShabbir Oct 13, 2025

openshift-merge-bot bot merged commit 7bc87ea into redhat-developer:main Oct 13, 2025
17 checks passed

christoph-jerolimov mentioned this pull request Oct 13, 2025

fix(marketplace): remove dynamic-plugins-info plugins #3539

Closed

rm3l mentioned this pull request Oct 15, 2025

ci: Fix E2E test by handling API change in RHDH 1.8+ redhat-developer/rhdh-operator#1749

Merged

2 tasks

fix(marketplace): remove dynamic-plugins-info plugins #3366

fix(marketplace): remove dynamic-plugins-info plugins #3366

Uh oh!

Conversation

ciiay commented Sep 5, 2025 • edited by debsmita1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Which issue(s) does this PR fix

PR acceptance criteria

How to test changes / Special notes to the reviewer

Uh oh!

Uh oh!

debsmita1 Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

debsmita1 Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

christoph-jerolimov left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 18, 2025

Uh oh!

github-actions bot commented Sep 20, 2025

Uh oh!

github-actions bot commented Oct 12, 2025

Uh oh!

ciiay commented Oct 13, 2025

Uh oh!

lokanandaprabhu commented Oct 13, 2025

Uh oh!

invincibleJai commented Oct 13, 2025

Uh oh!

sanketpathak commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HusneShabbir commented Oct 13, 2025

Uh oh!

debsmita1 commented Oct 13, 2025

Uh oh!

debsmita1 left a comment

Choose a reason for hiding this comment

Uh oh!

HusneShabbir commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

Uh oh!

debsmita1 commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ciiay commented Sep 5, 2025 •

edited by debsmita1

Loading

openshift-ci bot commented Oct 13, 2025 •

edited

Loading