Skip to content

👷 Remove defunct strictOptionalProperties refs #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Shrugsy
Copy link
Collaborator

@Shrugsy Shrugsy commented Jun 26, 2021

Should allow the ts-next task to pass again.

On TS-next, strictOptionalProperties has been renamed, and is now opt-in. As a result, the allowances previously made to account for it are no longer necessary, and currently cause an error due to the now non-existent property.

See microsoft/TypeScript#44626

@Shrugsy Shrugsy requested a review from phryneas June 26, 2021 04:26
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 65f7fb3:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@Shrugsy Shrugsy marked this pull request as ready for review June 26, 2021 04:30
@netlify
Copy link

netlify bot commented Jun 26, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: 65f7fb3

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60d6ac75270bd700072f5298

😎 Browse the preview: https://deploy-preview-1219--redux-starter-kit-docs.netlify.app

@phryneas phryneas merged commit a460453 into reduxjs:master Jun 26, 2021
@phryneas
Copy link
Member

Thanks :)

@Shrugsy Shrugsy deleted the ci/remove-defunct-strictOptionalProperties branch June 26, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants