Use test helpers and fixtures from b2sdk #349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlech-reef
approved these changes
Oct 22, 2025
There was a problem hiding this comment.
The PR generally looks good.
The only issue is the commit history, could you kindly clean it up (using an interactive rebase probably)? @kacper-wolkiewicz-reef
Commits like the following pollute the history making it less pleasant to work with:
Merge remote-tracking branch 'origin/master' into B2-171-tests-commons
Merge remote-tracking branch 'reef/master' into test-commons-2
Rebase should be preferred when pulling remote changes, especially when it comes to open source projects like Backblaze.
Apart from that, nicely done
| fail-fast: false | ||
| matrix: | ||
| os: ["ubuntu-latest", "ubuntu-24.04-arm", "macos-latest", "windows-latest"] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "pypy3.9", "pypy3.10"] |
There was a problem hiding this comment.
It's extremely advisable to extract such changes into a separate PR.
I assume dropping Python 3.8 support was needed to bump the sdk version, but it would have been much better if we had a separate PR for it first.
kacper-wolkiewicz-reef
force-pushed
the
test-commons-2
branch
from
5c9b841 to
94ffd75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, because PR in b2sdk must be pulled first (Backblaze/b2-sdk-python#547), release done and library version bumped. Otherwise ready for a review.
Basically the same as Backblaze#1110 but with new commit to use RNG from b2sdk.