Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Dashboard page #102

Closed

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Apr 5, 2025

Description

This PR refactors the Dashboard page removing unnecessary components and improving the CoachingSessionList component to display upcoming/previous sessions in two different tabs.

It also improves the logout robustness, but a separate PR will be necessary to fully address #101

Note

  1. @calebbourg's PR Update coaching sessions #96 must land first.
  2. Also, this backend PR must also land to ensure logout works well

GitHub Issue: Closes #87

Changes

  • Removes the SelectCoachingRelationship component from the Dashboard page
  • Moves CoachingSessionList left and widens it to the full page width
  • Adds a tab bar splitting sessions out by upcoming/previous sessions in the CoachingSessionList component
  • Move the CoachingSessionSelector into the CoachingSessionList
  • Addresses some of the logout robustness issues which was necessary to fully test the placeholder text of the CoachingSessionSelector component

Screenshots / Videos Showing UI Changes (if applicable)

No relationship selected:
Screenshot 2025-04-07 at 16 50 04

Relationship selected, upcoming sessions:
Screenshot 2025-04-07 at 16 50 25

Relationship selected, previous sessions:
Screenshot 2025-04-07 at 16 50 48

Testing Strategy

  1. Login as a user
  2. Notice the new CoachingSessionList component changes on the Dashboard page that should look like in the screenshots
  3. Notice that the SelectCoachingRelationship component is now removed from the Dashboard page
  4. Logout should work in every circumstance except for when the backend is down/unreachable

Concerns

None

@jhodapp jhodapp added enhancement Improves existing functionality or feature feature work Specifically implementing a new feature labels Apr 5, 2025
@jhodapp jhodapp added this to the 1.0-beta1 milestone Apr 5, 2025
@jhodapp jhodapp self-assigned this Apr 5, 2025
@jhodapp jhodapp moved this to 🏗 In progress in Refactor Coaching Platform Apr 5, 2025
jhodapp added 2 commits April 7, 2025 16:38
…or the layout of this component on the Dashboard page, and make logout more robust.
@jhodapp jhodapp marked this pull request as ready for review April 7, 2025 22:44
@jhodapp
Copy link
Member Author

jhodapp commented Apr 8, 2025

Replaced by #104.

@jhodapp jhodapp closed this Apr 8, 2025
@github-project-automation github-project-automation bot moved this from Review to ✅ Done in Refactor Coaching Platform Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature feature work Specifically implementing a new feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Refactor the coaching sessions component
2 participants