Refactor Dashboard page - remove org and rel selectors and enhance sessions list #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age. Moves CoachingSessionList left. Adds a tab bar splitting sessions out by upcoming/previous sessions.
…or the layout of this component on the Dashboard page, and make logout more robust.
…rer and nicer to read.
jhodapp
changed the title
calebbourg
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
@jhodapp looks great! I left some thoughts but I don't feel strong enough about any of it to request changes. Curious on your thoughts though.
src/middleware.ts
Outdated
| @@ -19,18 +19,18 @@ export default async function middleware(req: NextRequest) { | |||
|
|
|||
| // 3. Get the session from the cookie | |||
| const sessionCookie = req.cookies.get("id"); | |||
| const session = sessionCookie?.value; | |||
| const validSession = sessionCookie?.value; | |||
There was a problem hiding this comment.
I wonder if isValidSession would make sense here? Especially since we're treating it as a boolean in, from what I can tell, every use.
The main reason I bring it up is that it feels somewhat misleading to call it validSession when it actually could represent a not valid session.
or if you wanted to be more explicit you could do something maybe like:
Suggested change
| const validSession = sessionCookie?.value; | |
| const isValidSession = !!sessionCookie?.value; |
That way there is not ambiguity.
Probably not a huge deal either way. I don't consider it a blocker
src/types/coaching-session.ts
Outdated
| } | ||
|
|
||
| // export function sortCoachingSessionArray( |
jhodapp
deleted the
remove_org_and_rel_selectors_and_enhance_sessions_list
branch
github-project-automation
bot
moved this from Review
to ✅ Done
in Refactor Coaching Platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the Dashboard page removing unnecessary components and improving the CoachingSessionList component to display upcoming/previous sessions in two different tabs.
It also improves the logout robustness, but a separate PR will be necessary to fully address #101
Notes
GitHub Issue: Closes #87
Changes
Screenshots / Videos Showing UI Changes (if applicable)
No relationship selected:
Relationship selected, upcoming sessions:
Relationship selected, previous sessions:
Testing Strategy
Concerns
None