Fixed copy_repo copied all content types when copying only rpms #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DST-28235] copy_repo creates a criteria matching the content_type_id for non-rpm content types. However, in Pulp the type_ids filter with empty type_ids list included all the content types in the result. Hence, the copy-repo copied all the content types when requested only for rpms, as it generated an empty type_ids list for non-rpms. Hence, this adds a check to skip empty type_ids/content_type_id list.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 3010 3011 +1
=========================================
+ Hits 3010 3011 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy_repo creates a criteria matching the content_type_id for non-rpm content types. However, in Pulp the type_ids filter with empty type_ids list included all the content types in the result. Hence, the copy-repo copied all the content types when requested only for rpms, as it generated an empty type_ids list for non-rpms. Hence, this adds a check to skip empty type_ids/content_type_id list.