Skip to content

Fixed copy_repo copied all content types when copying only rpms #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajulkumar merged 1 commit into from
Dec 23, 2024
Merged

Fixed copy_repo copied all content types when copying only rpms #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/pubtools/_pulp/tasks/copy_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,14 @@ def str_to_content_type(content_type_id):
# criteria for all non-rpm content types
# unit_fields are ignored as they are small in size and the repos have
# small unit counts for non-rpm content types
criteria.append(
Criteria.with_field(
"content_type_id", Matcher.in_(sorted(non_rpm_content_types))
if non_rpm_content_types:
# type_id filter with empty list includes all the content types.
# hence, check for the presence of non-rpm content types.
criteria.append(
Criteria.with_field(
"content_type_id", Matcher.in_(sorted(non_rpm_content_types))
)
)
)

# criteria for rpm content types
# unit_fields to keep a check on memory consumption with large rpm unit
Expand Down
Loading