fix: correct EAS install guidance - #618
Open
DavidJGrimsley wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the post-generation EAS guidance so dependency install instructions are only printed when the project was generated with --no-install, and adds a patch changeset to release the fix.
Changes:
- Flip the EAS completion-output install-step condition to run only under
flags.noInstall. - Apply the same fix to both EAS “development” and “preview” instruction blocks.
- Add a patch changeset for
create-expo-stackandrn-new.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cli/src/utilities/printOutput.ts |
Fixes EAS “next steps” output to show packageManager install only for no-install flows. |
.changeset/eas-install-guidance.md |
Adds a patch changeset documenting the corrected EAS output guidance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-installcreate-expo-stackandrn-newContext
This was split out of #616 because it is independent of the Expo SDK 57 upgrade. In the normal EAS flow, dependencies have already been installed before the final instructions print, so the extra install step is redundant.
Verification
bun run build:cliI also attempted
bun run testfromcli/, but the main-branch NativeWindUI generation path hung innwui-cliand the command timed out after 5 minutes before producing test output. The CLI build/typecheck completed successfully.