Skip to content

fix: correct EAS install guidance #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidJGrimsley wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

fix: correct EAS install guidance #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/eas-install-guidance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'create-expo-stack': patch
'rn-new': patch
---

Correct EAS completion output so install steps are shown only for no-install flows.
4 changes: 2 additions & 2 deletions cli/src/utilities/printOutput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ export async function printOutput(
info(`To build for development:`);
info(``);
highlight(`${step}. cd ${projectDir}`);
if (!flags.noInstall) highlight(`${++step}. ${packageManager} install`);
if (flags.noInstall) highlight(`${++step}. ${packageManager} install`);
highlight(`${++step}. eas build --profile=development`);
highlight(`${++step}. ${runCommand} start`);

Expand All @@ -274,7 +274,7 @@ export async function printOutput(
info(`To create a build to share with others:`);
info(``);
highlight(`${step}. cd ${projectDir}`);
if (!flags.noInstall) highlight(`${++step}. ${packageManager} install`);
if (flags.noInstall) highlight(`${++step}. ${packageManager} install`);
highlight(`${++step}. eas build --profile=preview`);

info(``);
Expand Down
Loading