Skip to content

[core] proper check whether class is a TRef or TRefArray #14930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ferdymercury
Copy link
Contributor

This Pull request:

Changes or fixes:

Fixes https://its.cern.ch/jira/projects/ROOT/issues/ROOT-7052 reported by @olifre

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@ferdymercury

This comment was marked as outdated.

This comment was marked as outdated.

@ferdymercury
Copy link
Contributor Author

I'll try now with TRefArrayProxy

No luck.

@pcanal
Copy link
Member

pcanal commented Mar 11, 2024

No luck.

Are you able to reproduce the failure locally? If not, you can use something like:

   //check if element is a TRef or TRefArray
   const bool originalTest = (strncmp(fTypeName.Data(),"TRef",4) != 0);
   TClass* const type = GetClassPointer();
   const bool newTest = (!type || !(type->InheritsFrom(TRef::Class()) || type->InheritsFrom(TRefArray::Class()) || type->InheritsFrom("TVirtualRefProxy"))
   if (originalTest != newTest)
		Fatal("GetExecID", "Problem with type %s original test %d, new test %d\n", 
                  fTypeName.Data(), originalTest, newTest);
   if (originalTest) return 0;

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@phsft-bot

This comment was marked as outdated.

@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@root-project root-project deleted a comment from phsft-bot Jan 2, 2025
@dpiparo dpiparo closed this Feb 14, 2025
@dpiparo dpiparo reopened this Feb 14, 2025
@dpiparo
Copy link
Member

dpiparo commented Feb 14, 2025

time to retest

@ferdymercury
Copy link
Contributor Author

Same issue :(

@dpiparo
Copy link
Member

dpiparo commented Apr 21, 2025

Trying to build on this solid work with this attempt: #18450

@ferdymercury ferdymercury deleted the trefarr branch April 21, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants