Skip to content

[meta] Return exec id of TRef, TRefArray and derived data members #18450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpiparo
Copy link
Member

@dpiparo dpiparo commented Apr 21, 2025

Instead of all data members the type of which has a name beginning with "TRef".

Fixes ROOT-7052

This PR builds on top of the solid work done here #14930.

Instead of all data members the type of which has a name beginning
with "TRef".

Fixes ROOT-7052
@dpiparo dpiparo self-assigned this Apr 21, 2025
@dpiparo dpiparo requested a review from pcanal as a code owner April 21, 2025 17:31
@pcanal pcanal added this to the 6.38.00 milestone Apr 21, 2025
@ferdymercury
Copy link
Contributor

ferdymercury commented Apr 21, 2025

Thanks a lot! Optional idea: could you add and updates fClassObject. on line 287 ?

Copy link

Test Results

    18 files      18 suites   3d 23h 49m 50s ⏱️
 2 744 tests  2 743 ✅ 0 💤 1 ❌
47 708 runs  47 707 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 384b44a.

@dpiparo
Copy link
Member Author

dpiparo commented Apr 22, 2025

Yes, I focussed on the functional change before. I'll make that part of the new version of the PR after the review.

@ferdymercury
Copy link
Contributor

@olifre Do you happen to still have a reproducer/test for this issue of yours with a class CBTRef deriving from TRef, that you could share?

@olifre
Copy link
Contributor

olifre commented Apr 25, 2025

@olifre Do you happen to still have a reproducer/test for this issue of yours with a class CBTRef deriving from TRef, that you could share?

Sadly, I have no example at hand 😢 . As far as I remember, I think I tried this in the context of a larger framework with classes inheriting from TRef and then did not continue to create a minimal reproducer, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants