Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service for reading PIDs as well pid initialisation with weight… #45

Open
wants to merge 7 commits into
base: indigo-devel
Choose a base branch
from

Conversation

cehberlin
Copy link

…s of first pid controller if several controllers are added to the pid gain setter in order to mimic the idea of setting simlar weights to all controllers like done in setGains

cehberlin added 2 commits July 1, 2015 15:26
…s of first pid controller if several controllers are added to the pid gain setter in order to mimic the idea of setting simlar weights to all controllers like done in setGains
@adolfo-rt
Copy link
Member

Instead of a ROS service, would a topic broadcasting PID state work for you as well?. Take a look at ros-controls/control_msgs#14. The message is quite complete, and exposes PID gains, among other things.

@cehberlin
Copy link
Author

I my case as well as in general I think it is much more useful to get this information on request, since it is not data that is frequently changed. Moreover, I would like to have it directly instead of waiting for a topic message.

Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Mar 31, 2025
Copy link

mergify bot commented Mar 31, 2025

This pull request is in conflict. Could you fix it @cehberlin?

Copy link

mergify bot commented Mar 31, 2025

@cehberlin, all pull requests must be targeted towards the ros2-master development branch.
Once merged into ros2-master, it is possible to backport to indigo-devel, but it must be in ros2-master
to have these changes reflected into new distributions.

@github-actions github-actions bot removed the stale label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants