Skip to content

Add AckermannDriveStamped control to steering library #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

wittenator
Copy link

@wittenator wittenator commented Mar 1, 2025

This PR adds the option to use steering angle and linear velocity for controllers that inherit from the steering library.

To send us a pull request, please:

  • Fork the repository.
  • Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
  • Ensure local tests pass. (colcon test and pre-commit run (requires you to install pre-commit by pip3 install pre-commit)
  • Commit to your fork using clear commit messages.
  • Send a pull request, answering any default questions in the pull request interface.
  • Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.

@wittenator wittenator changed the title Add AckermannDriveStamped control to steering library WIP: Add AckermannDriveStamped control to steering library Mar 1, 2025
@wittenator
Copy link
Author

wittenator commented Mar 1, 2025

The tests on HEAD are currently broken, but I wanted to get this PR out in order to track progress.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why WIP?
Please fix the failing jobs, start with the pre-commit and clang job.
The tests on the master branch are green.

@wittenator wittenator changed the title WIP: Add AckermannDriveStamped control to steering library Add AckermannDriveStamped control to steering library Apr 11, 2025
@wittenator
Copy link
Author

@christophfroehlich I fixed all the pre-commit checks and the colcon test checks. I think this should be ready for a first review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants