-
Notifications
You must be signed in to change notification settings - Fork 363
Add AckermannDriveStamped control to steering library #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The tests on HEAD are currently broken, but I wanted to get this PR out in order to track progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why WIP?
Please fix the failing jobs, start with the pre-commit and clang job.
The tests on the master branch are green.
steering_controllers_library/include/steering_controllers_library/steering_odometry.hpp
Outdated
Show resolved
Hide resolved
@christophfroehlich I fixed all the pre-commit checks and the colcon test checks. I think this should be ready for a first review now. |
This PR adds the option to use steering angle and linear velocity for controllers that inherit from the steering library.
To send us a pull request, please:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)