-
Notifications
You must be signed in to change notification settings - Fork 390
Add motion_primitives_forward_controller
for interfacing motion primitive messages with hardware interfaces
#1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…time --> added gitignore, to not push it to github --> remove it after everything is done
… the hardware interface can receive a new motion primitive — replaces the previous, more complex handling via execution_status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of stuff coming from templates in this PR and you either used some AI tool for coding or you are very good at writing AI-style comments.
Please try removing all commented code or fix them and remove all comments that add nothing to the code itself (which in this code is almost all comments...)
...mitives_forward_controller/include/motion_primitives_forward_controller/visibility_control.h
Outdated
Show resolved
Hide resolved
motion_primitives_forward_controller/motion_primitives_forward_controller.rolling.repos
Outdated
Show resolved
Hide resolved
motion_primitives_forward_controller/test/test_motion_primitives_forward_controller.cpp
Outdated
Show resolved
Hide resolved
...roller/include/motion_primitives_forward_controller/motion_primitives_forward_controller.hpp
Outdated
Show resolved
Hide resolved
…ls according to other controllers in the repo
motion_primitives_forward_controller/src/motion_primitives_forward_controller.cpp
Outdated
Show resolved
Hide resolved
motion_primitives_forward_controller/src/motion_primitives_forward_controller.cpp
Outdated
Show resolved
Hide resolved
motion_primitives_forward_controller/src/motion_primitives_forward_controller.cpp
Outdated
Show resolved
Hide resolved
...roller/include/motion_primitives_forward_controller/motion_primitives_forward_controller.hpp
Outdated
Show resolved
Hide resolved
motion_primitives_forward_controller/src/motion_primitives_forward_controller.cpp
Outdated
Show resolved
Hide resolved
…ack after control_msg PR is merged
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1636 +/- ##
==========================================
- Coverage 86.44% 85.62% -0.82%
==========================================
Files 123 129 +6
Lines 12259 12641 +382
Branches 1023 1070 +47
==========================================
+ Hits 10597 10824 +227
- Misses 1344 1475 +131
- Partials 318 342 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
// Iterate over all command interfaces from the config yaml file | ||
for (const auto & interface_name : params_.command_interfaces) | ||
{ | ||
command_interfaces_config.names.push_back("motion_primitive/" + interface_name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, all 25 command interfaces are given to the controller and then added with the motion_primitive
prefix. The actual names of the interfaces don't matter as far as I can see from your implementation, they could also be i0
to i24
. The prefix, however (the gpio group name), has to be exactly motion_primitive
. That's not necessarily the case. As in your implementation for UR, the group name is ${tf_prefix}motion_primitive
which would mean that this controller would not work if a tf_prefix
is set. I would suggest to either
- pass full interface names to the controller (such as
$(var tf_prefix)motion_primitive/q1
) or - pass both, the group name and each interface name as separate parameters or
- Have the interface names fixed and only pass the group name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted it so that the full name is passed to the controller ($(var tf_prefix)motion_primitive/q1).
…motion_primitive/q1)
…atomic<bool> has_active_goal_ to ensure only one action goal is accepted at a time.
This PR adds the
motion_primitives_forward_controller
, a controller for forwarding motion primitive commands to motion-primitive-capable hardware interfaces.It was developed alongside the
motion_primitive_ur_driver
and is intended to support future hardware interfaces for additional robot manufacturers.The corresponding PR for integrating the
motion_primitive_ur_driver
into the official Universal Robots ROS 2 driver can be found here: UniversalRobots/Universal_Robots_ROS2_Driver#1341.The controller subscribes to
MotionPrimitive.msg
from theindustrial_robot_motion_interfaces
package. TheMotionPrimitive.msg
has been extended with additional helper types:STOP_MOTION
: Immediately interrupts execution and clears all queued primitives.MOTION_SEQUENCE_START
andMOTION_SEQUENCE_END
: Define a sequence of primitives to be executed as a blended motion block.The controller uses the following interfaces:
Command Interfaces
motion_type
: Type of motion primitive (e.g., LINEAR_JOINT, LINEAR_CARTESIAN, CIRCULAR_CARTESIAN, etc.)q1
–q6
: Target joint positions for joint-based motionpos_x
,pos_y
,pos_z
: Target Cartesian positionpos_qx
,pos_qy
,pos_qz
,pos_qw
: Orientation quaternion of the target posepos_via_x
,pos_via_y
,pos_via_z
: Intermediate via-point position for circular motionpos_via_qx
,pos_via_qy
,pos_via_qz
,pos_via_qw
: Orientation quaternion of via-pointblend_radius
: Blending radius for smooth transitionsvelocity
: Desired motion velocityacceleration
: Desired motion accelerationmove_time
: Optional duration for time-based executionState Interfaces
execution_status
: Indicates the current execution state of the primitive.ready_for_new_primitive
: Boolean flag indicating whether the interface is ready to receive a new motion primitiveI'd appreciate any feedback or suggestions – thanks in advance!