Skip to content

rcl_yaml_param_parser should not accept a relative name in a paramete… #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Draft

rcl_yaml_param_parser should not accept a relative name in a paramete… #928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions rcl_yaml_param_parser/src/parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,11 +494,7 @@ _validate_name(const char * name, rcutils_allocator_t allocator)
char * node_name = NULL;
char * absolute_namespace = NULL;
if (NULL == separator_pos) {
node_name = rcutils_strdup(name, allocator);
if (NULL == node_name) {
ret = RCUTILS_RET_BAD_ALLOC;
goto clean;
}
return RCUTILS_RET_INVALID_ARGUMENT;
} else {
// substring namespace including the last '/'
char * namespace_ = rcutils_strndup(name, ((size_t) (separator_pos - name)) + 1, allocator);
Expand All @@ -507,12 +503,8 @@ _validate_name(const char * name, rcutils_allocator_t allocator)
goto clean;
}
if (namespace_[0] != '/') {
absolute_namespace = rcutils_format_string(allocator, "/%s", namespace_);
allocator.deallocate(namespace_, allocator.state);
if (NULL == absolute_namespace) {
ret = RCUTILS_RET_BAD_ALLOC;
goto clean;
}
ret = RCUTILS_RET_INVALID_ARGUMENT;
goto clean;
} else {
absolute_namespace = namespace_;
}
Expand Down