Skip to content

subordinate node consistent behavior and update docstring. #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

subordinate node consistent behavior and update docstring. #2822

merged 3 commits into from
Apr 29, 2025

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya fujitatomoya commented Apr 21, 2025 •
edited
Loading

closes #2795

Note

extend_name_with_sub_namespace is inline function, so user must rebuild the application with rclcpp to get this fix. besides that, this is behavior change could break the application. i am not inclined to backport this. thoughts?

fujitatomoya
fujitatomoya commented Apr 21, 2025
View reviewed changes
@fujitatomoya
Copy link
Collaborator Author

@jmachowinski @mjcarroll can you review this?

@fujitatomoya
typo fixes.
a705ccc 
Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator Author

Pulls: #2822
Gist: https://gist.githubusercontent.com/fujitatomoya/4eae4734591a7b22690e7f7ed0abbcde/raw/defed4a27eb0e0fbfaab46dd7fc7a787ef29f8b6/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15726

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya self-assigned this Apr 22, 2025
@christophebedard
Copy link
Member

We can probably get this into Rolling during the freeze, before Kilted branches off (which it hasn't yet IIUC).

@fujitatomoya
Copy link
Collaborator Author

@christophebedard what do you think about backport ? #2822 (comment)

@christophebedard
Copy link
Member

Yeah, I agree, maybe we should hold off on backporting, at least for now. This is the kind of issue that users probably worked around. If someone requests a backport, then we can consider it more seriously.

@fujitatomoya
Copy link
Collaborator Author

Warning

DO NOT MERGE THIS, WE ARE NOW BRANCHING KILTED.

@fujitatomoya fujitatomoya merged commit c89a2b1 into rolling Apr 29, 2025
2 of 3 checks passed
@fujitatomoya
Copy link
Collaborator Author

@Mergifyio backport kilted

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2025 •
edited
Loading

backport kilted

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 29, 2025
@fujitatomoya @mergify
subordinate node consistent behavior and update docstring. (#2822)
918ddf9 
* subordinate node consistent behavior and update docstring.

Signed-off-by: Tomoya Fujita <[email protected]>

* add subnode_parameter_operation test.

Signed-off-by: Tomoya Fujita <[email protected]>

* typo fixes.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit c89a2b1)
@mergify mergify bot mentioned this pull request Apr 29, 2025
Merged
fujitatomoya added a commit that referenced this pull request Apr 30, 2025
@mergify @fujitatomoya
subordinate node consistent behavior and update docstring. (#2822) (#…
93028ff 
…2830)

* subordinate node consistent behavior and update docstring.



* add subnode_parameter_operation test.



* typo fixes.



---------


(cherry picked from commit c89a2b1)

Signed-off-by: Tomoya Fujita <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
@christophebedard christophebedard mentioned this pull request Apr 30, 2025
Merged
@christophebedard christophebedard deleted the fujitatomoya/sub-node-fix branch April 30, 2025 15:40
@mergify mergify bot mentioned this pull request Apr 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwwood wjwwood wjwwood approved these changes

@christophebedard christophebedard christophebedard approved these changes

@jmachowinski jmachowinski Awaiting requested review from jmachowinski

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rclcpp::Node::get_parameter overloads undocumented inconsistent behavior
3 participants
@fujitatomoya @christophebedard @wjwwood