add : get clients, servers info #1307
Conversation
|
Dependencies |
rclpy/rclpy/node.py
Outdated
| self, | ||
| service_name: str, | ||
| no_mangle: bool = False | ||
| ) -> List[TopicEndpointInfo]: |
There was a problem hiding this comment.
instead we could return ServiceEndpointInfo?
I think we can introduce EndpointInfo base class then TopicEndpointInfo and ServiceEndpointInfo can inherit EndpointInfo base class. this is more appropriate implementation since TopicEndpointInfo for services does not have topic type, topic type hash. this requires the bit of refactoring for classes, but i think that is the right path we can take here.
@clalancette @sloretz what do you think?
rclpy/rclpy/node.py
Outdated
| name, otherwise it should be a valid ROS service name. Defaults to ``False``. | ||
| :return: A list of TopicEndpointInfo for all the clients on this service. | ||
| """ | ||
| return self._get_info_by_topic( |
There was a problem hiding this comment.
how about having EndpointTypeEnum instead of TopicEndpointTypeEnum, and this function can take an argument with EndpointTypeEnum, and callback function together? i think this refactoring would be useful when we support the action endpoints in rclpy.
| return self._get_info_by_topic( | |
| return self._get_info_by_endpoint( |
Signed-off-by: Minju, Lee <[email protected]>
leeminju531
force-pushed
the
add-clients-servers-info
branch
from
3294bf1 to
bd58f38
Compare
|
Pulls: ros2/rmw#371, ros2/rmw_implementation#238, ros2/rcl#1161, ros2/rclcpp#2569, #1307, ros2/rmw_zenoh#679, ros2/rmw_fastrtps#771, ros2/rmw_cyclonedds#499, ros2/rmw_connextdds#154, ros2/ros2cli#916
|
Add get clients, servers info
Refer to ros2/ros2cli#916