Synchronize the Shoryuken::Client queue cache#1013
Draft
mensfeld wants to merge 3 commits into
Draft
Conversation
Client.queues cached queues with an unsynchronized `@@queues[name] ||= Shoryuken::Queue.new(...)`. Building a queue makes SQS API calls, and that I/O releases the GVL, so concurrent first-access - the dispatch thread, processor-completion threads and worker threads all call Client.queues - built the same queue multiple times: redundant get_queue_url/get_queue_attributes calls, and a corrupt cache hash on JRuby/TruffleRuby. Access to the cache (and the reset in sqs=) is now guarded by a class-level mutex. The lock is held during construction, but queues are built once at first access (and pre-cached at startup by validate_queues), so steady-state lookups are fast hash reads. Coverage: - unit spec that 10 concurrent first-access callers build the queue only once (got 10 before the fix, since Queue construction sleeps/IO releases the GVL)
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client.queues cached queues with an unsynchronized
@@queues[name] ||= Shoryuken::Queue.new(...). Building a queue makes SQS API calls, and that I/O releases the GVL, so concurrent first-accessAccess to the cache (and the reset in sqs=) is now guarded by a class-level mutex. The lock is held during construction, but queues are built once at first access (and pre-cached at startup by validate_queues), so steady-state lookups are fast hash reads.
Coverage: