Fix sqs CLI crash sizing message attributes without a scalar value#1026
Draft
mensfeld wants to merge 1 commit into
Draft
Fix sqs CLI crash sizing message attributes without a scalar value#1026mensfeld wants to merge 1 commit into
mensfeld wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bin/cli/sqs requeue/mv compute each message's payload size via message_size. For a message attribute that has a :data_type but neither :string_value nor :binary_value - e.g. a list-type attribute, whose value normalize_dump_message intentionally drops - value_size was nil and `name_size + data_type_size + value_size` raised TypeError: nil can't be coerced into Integer, aborting the whole requeue/mv batch. Default the size of such value-less attributes to 0. (No spec: the CLI defines Shoryuken::CLI, and Shoryuken#server? is `defined?(Shoryuken::CLI)`, so loading bin/cli into the in-process suite would flip server? globally and break client-middleware specs. Adding a CLI test harness that isolates that is out of scope for this fix.)
mensfeld
force-pushed
the
fix/b7-cli-message-size-crash
branch
from
0cb4a18 to
5d26076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/cli/sqs requeue/mv compute each message's payload size via message_size. For a message attribute that has a :data_type but neither :string_value nor :binary_value - e.g. a list-type attribute, whose value normalize_dump_message intentionally drops - value_size was nil and
name_size + data_type_size + value_sizeraisedTypeError: nil can't be coerced into Integer, aborting the whole requeue/mv batch.
Default the size of such value-less attributes to 0. Adds a spec.