Skip to content

Fix sqs CLI crash sizing message attributes without a scalar value #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mensfeld wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Draft

Fix sqs CLI crash sizing message attributes without a scalar value #1026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bin/cli/sqs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@ def message_size(message)
value[:string_value].bytesize
elsif value[:binary_value]
value[:binary_value].bytesize
else
# List-type attributes (string_list_values /
# binary_list_values) carry no scalar value here and
# are intentionally not requeued (see
# normalize_dump_message). Size them as 0 rather than
# crashing the whole batch with `nil + Integer`.
0
end
name_size + data_type_size + value_size
end
Expand Down