-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style: Add left margin for columns on all screen sizes #786
Conversation
It seems we're not supposed to modify |
Ah, I see, thanks for pointing that out. It doesn't seem like your questions from that PR regarding where to put new CSS were ever answered, but do you know where new style changes should go? It seem like |
I've moved my change over to |
Yeah, I don't know unfortunately.
If that works out for you, I might try that in my own PR. Thanks :) |
@rbuch sorry for letting this sit for so long. Is this just waiting for approval? |
No worries. Yeah, it should be good to go, just needs approval. |
I opened an issue for this not knowing there was a PR already! I think this would be good to get back on track :) Fixes #1485 |
Previously,
.column
and.columns
only had amargin-left
of4%
when the viewport satisfiedmin-width:550px
. On mobile, this led to the columns in the footer abutting each other with no space in between (see "Before" screenshot, in particular the "Contact the Rust Team" and "Licenses" lines). This change gives.column
and.columns
a left margin of4%
at all screen widths, giving the columns a bit of breathing room. Before and after screenshots are given below, as rendered by Firefox's Responsive Design Mode using the Pixel 2 template.Before:

After:
