Fix: avoid -C prefer-dynamic for test harnesses of proc-macro crates #16024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16000.
When running
cargo test --no-runon a proc-macro crate with a dev-dependency on adylib, Cargo was incorrectly passing-C prefer-dynamicto the test harness.That caused rustc to try to link both
rlibanddylibforms ofstdand its transitive crates, resulting in errors like:What changed
core/compilerso that-C prefer-dynamicis only applied when compiling an actual proc-macro crate.-C prefer-dynamic.Why
This resolves the duplicate
std/core/alloclinkage errors and makescargo test --no-runconsistent withcargo build.