Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't single out intra-doc links as causing rollups to fail #439

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Sep 15, 2020

There have been a lot of bugs fixed in intra-doc links lately and they are being stabilized in the next release. Additionally, almost all intra-doc issues are caught in the PR build, before they get to bors; the only exceptions I can think of have to do with cfg(platform), which should be comparatively rare (rust-lang/rust#76526) and no more likely to fail than linkcheck failures.

There have been a lot of bugs fixed in intra-doc links lately and they are being stabilized in the next release. Additionally, almost all intra-doc issues are caught in the PR build, before they get to bors; the only exceptions I can think of have to do with `cfg(platform)`, which should be comparatively rare: rust-lang/rust#76526.
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dtolnay dtolnay merged commit 692cda3 into rust-lang:master Sep 15, 2020
@jyn514 jyn514 deleted the patch-1 branch September 15, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants