Skip to content

Don't single out intra-doc links as causing rollups to fail #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Don't single out intra-doc links as causing rollups to fail #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/maintaining-std.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ PRs to [`rust-lang/rust`] aren’t merged manually using GitHub’s UI or by pus

### When to `rollup`

For Libs PRs, rolling up is usually fine, in particular if it's only a new unstable addition or if it only touches docs (with the exception of intra doc links which complicates things while the feature has bugs...).
For Libs PRs, rolling up is usually fine, in particular if it's only a new unstable addition or if it only touches docs.

See the [rollup guidelines] for more details on when to rollup.

Expand Down