test(cli-self-upd): migrate to .expect() APIs#4343
Merged
rami3l merged 2 commits intorust-lang:masterfrom May 31, 2025
Merged
Conversation
rami3l
force-pushed
the
test/new-apis
branch
3 times, most recently
from
1b31824 to
bd070c4
Compare
FranciscoTGouveia
added a commit
to FranciscoTGouveia/rustup
that referenced
this pull request
May 26, 2025
This change is done to be consistent with the new migration to the `.expect()` API's that were defined in rust-lang#4334 and rust-lang#4342, and are showcased in the latest PR for migration (rust-lang#4343).
FranciscoTGouveia
added a commit
to FranciscoTGouveia/rustup
that referenced
this pull request
May 28, 2025
…targets Since we can now list the available targets for a custom toolchain, this test needed to be updated. This is consistent with the new migration to the `.expect()` API's that were showcased in rust-lang#4343.
rami3l
pushed a commit
to FranciscoTGouveia/rustup
that referenced
this pull request
May 28, 2025
…targets Since we can now list the available targets for a custom toolchain, this test needed to be updated. This is consistent with the new migration to the `.expect()` API's that were showcased in rust-lang#4343.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 28, 2025
…targets Since we can now list the available targets for a custom toolchain, this test needed to be updated. This is consistent with the new migration to the `.expect()` API's that were showcased in #4343.
ChrisDenton
reviewed
May 31, 2025
Member
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
Looks good to me. I just have one question.
ChrisDenton
approved these changes
May 31, 2025
Member
Author
|
^ I have re-organized the commits so the migration of old tests to snapshot ones and the migration of existing snapshot tests to new redactions are properly separated. |
This was referenced May 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4359.
SemanticDiff