feat(custom-toolchains): targets and components are now reported for custom toolchains #4347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
reviewed
May 26, 2025
rami3l
reviewed
May 26, 2025
rami3l
approved these changes
May 28, 2025
…tom toolchains As we cannot assume the existence of a manifest for custom toolchains, we can only report the installed components/targets. Thus, running `rustup target list` or `rustup target list --installed`, will yield the same result. The `list_items()` function was also refactored so that both custom and distributable toolchains can make use of it.
FranciscoTGouveia
force-pushed
the
report-targets-custom-toolchains
branch
from
825052c to
577abcf
Compare
…targets Since we can now list the available targets for a custom toolchain, this test needed to be updated. This is consistent with the new migration to the `.expect()` API's that were showcased in rust-lang#4343.
rami3l
force-pushed
the
report-targets-custom-toolchains
branch
from
577abcf to
2dd4a29
Compare
rami3l
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4333.
Instead of throwing an error,
rustup target listandrustup component listnow display the installed targets and components, respectively, for custom toolchains.Similar to the previous PR, this assumes that there may not be a manifest file for custom toolchains. As a result, there is a minor inconsistency: using
target/component listwithout the--installedflag always yields the same result as using it with the flag.Thank you in advance for your time and input!