-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use # in tests tags 320 #5382
Merged
Merged
Use # in tests tags 320 #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 46ac401 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Differences Found✅ No packages or licenses were added. SummaryExpand
|
szczecha
force-pushed
the
qa-282-replace-tags-in-tests-320
branch
from
January 30, 2025 13:20
2706dca
to
74be194
Compare
This was referenced Feb 3, 2025
Merged
michalina-graczyk
approved these changes
Feb 4, 2025
add changeset
szczecha
force-pushed
the
qa-282-replace-tags-in-tests-320
branch
from
February 5, 2025 13:27
74be194
to
46ac401
Compare
poulch
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the change
While working on adding #5356 (comment), we realized that our test tags match the GitHub usernames of actual users. This unintentionally mentions them in reports, which is not ideal.
Internal task: https://linear.app/saleor/issue/QA-282/
It should be merged along with:
#5379
#5383