Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use # in tests tags 320 #5382

Merged
merged 1 commit into from
Feb 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lucky-windows-sin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Test reports no longer mention users due to test tags matching GitHub usernames.
2 changes: 1 addition & 1 deletion .github/actions/run-pw-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ runs:
PROJECT_PARAMS+="--project=${PROJECT} "
done
echo "reportName=all-blob-reports-${SHARD_NUMBER%%/*}" >> $GITHUB_ENV
npx playwright test --grep @e2e $PROJECT_PARAMS --shard "$SHARD_NUMBER"
npx playwright test --grep "#e2e" $PROJECT_PARAMS --shard "$SHARD_NUMBER"

- name: Upload blob report to GitHub Actions Artifacts
uses: actions/upload-artifact@v4
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,10 @@
"qa:move-videos": "find cypress/videos -type f -name \"*.js.mp4\" -exec mv {} cypress/reports/mochareports/videos \\;",
"qa:artifact-move-screenshots": "find cypress/reports/*/mochareports -type d -name \"*.js\" -exec mv {} cypress/reports/mochareports \\;",
"qa:artifact-move-videos": "find cypress/reports/*/mochareports/videos -type f -name \"*.js.mp4\" -exec mv {} cypress/reports/mochareports/videos \\;",
"qa:pw-e2e": "npx playwright test --grep @e2e",
"qa:pw-e2e": "npx playwright test --grep \"#e2e\"",
"qa:pw-ui": "npx playwright test --ui",
"knip": "knip --reporter markdown",
"knip:fix": "knip --fix"
},
"description": "![Saleor Dashboard](https://user-images.githubusercontent.com/44495184/185379472-2a204c0b-9b7a-4a3e-93c0-2cb85205ed5e.png)"
}
}
4 changes: 2 additions & 2 deletions playwright/tests/apps.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const PRE_INSTALLATION_TIMEOUT = 20 * 1000;
const INSTALLATION_PENDING_TIMEOUT = 50 * 1000;
const APP_EXPECT_UI_TIMEOUT = 15 * 1000;

test("TC: SALEOR_119 User should be able to install and configure app from manifest @e2e", async ({
test("TC: SALEOR_119 User should be able to install and configure app from manifest #e2e", async ({
page,
}) => {
await appsPage.gotoAppsList();
Expand Down Expand Up @@ -56,7 +56,7 @@ test("TC: SALEOR_119 User should be able to install and configure app from manif
await iframeLocator.getByText("Save").click();
await appsPage.expectSuccessBanner({ timeout: INSTALLATION_PENDING_TIMEOUT });
});
test("TC: SALEOR_120 User should be able to delete thirdparty app @e2e", async () => {
test("TC: SALEOR_120 User should be able to delete thirdparty app #e2e", async () => {
await appPage.waitForNetworkIdleAfterAction(() =>
appPage.goToExistingAppPage(APPS.appToBeDeleted.id),
);
Expand Down
14 changes: 7 additions & 7 deletions playwright/tests/attributes.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ for (const attr of attributeClasses) {
for (const type of ATTRIBUTES.attributeTypesWithAbilityToAddValues.names) {
const uniqueSlug = `${attr}-${type}-${SALEOR_124_uuid}`.replace(/\s+/g, "-");

test(`TC: SALEOR_124 User should be able to create ${attr} ${type} attribute with ability to add values, required, public @e2e @attributes`, async ({
test(`TC: SALEOR_124 User should be able to create ${attr} ${type} attribute with ability to add values, required, public #e2e #attributes`, async ({
page,
}) => {
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
Expand Down Expand Up @@ -56,7 +56,7 @@ for (const attr of attributeClasses) {
for (const type of ATTRIBUTES.attributeTypesWithoutAbilityToAddValues.names) {
const uniqueSlug = `${attr}-${type}-${SALEOR_125_uuid}`.replace(/\s+/g, "-");

test(`TC: SALEOR_125 User should be able to create ${attr} ${type} attribute without ability to add values, NOT required, private @e2e @attributes`, async ({
test(`TC: SALEOR_125 User should be able to create ${attr} ${type} attribute without ability to add values, NOT required, private #e2e #attributes`, async ({
page,
}) => {
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
Expand Down Expand Up @@ -91,7 +91,7 @@ for (const attr of attributeClasses) {
for (const entity of ATTRIBUTES.attributeReferencesEntities.names) {
const uniqueSlug = `${attr}-${entity}-${SALEOR_126_uuid}`.replace(/\s+/g, "-");

test(`TC: SALEOR_126 User should be able to create ${attr} References attribute for ${entity}, NOT required, public @e2e @attributes`, async ({
test(`TC: SALEOR_126 User should be able to create ${attr} References attribute for ${entity}, NOT required, public #e2e #attributes`, async ({
page,
}) => {
await page.context().storageState({ path: "./playwright/.auth/admin.json" });
Expand Down Expand Up @@ -133,7 +133,7 @@ const contentAttrWithValues = {
const attributesWithValuesToBeUpdated = [productAttrWithValues, contentAttrWithValues];

for (const attribute of attributesWithValuesToBeUpdated) {
test(`TC: SALEOR_127 User should be able to update attribute values in existing ${attribute.name} attribute @e2e @attributes`, async () => {
test(`TC: SALEOR_127 User should be able to update attribute values in existing ${attribute.name} attribute #e2e #attributes`, async () => {
await attributesPage.gotoExistingAttributePage(attribute.id, attribute.name);
await attributesPage.clickDeleteAttrValueButton(attribute.valueToBeDeleted);
await expect(attributesPage.dialog).toBeVisible();
Expand All @@ -160,7 +160,7 @@ for (const attribute of attributesWithValuesToBeUpdated) {
}

for (const attr of ATTRIBUTES.attributesToBeUpdated) {
test(`TC: SALEOR_128 User should be able to edit existing ${attr.name} attribute @e2e @attributes`, async () => {
test(`TC: SALEOR_128 User should be able to edit existing ${attr.name} attribute #e2e #attributes`, async () => {
await attributesPage.gotoExistingAttributePage(attr.id, attr.name);

await attributesPage.attributeDefaultLabelInput.fill(`updated ${attr.name}`);
Expand Down Expand Up @@ -198,7 +198,7 @@ const contentAttribute = {
const attributesToBeDeleted = [productAttribute, contentAttribute];

for (const attribute of attributesToBeDeleted) {
test(`TC: SALEOR_129 Delete a single ${attribute.name} @e2e @attributes`, async () => {
test(`TC: SALEOR_129 Delete a single ${attribute.name} #e2e #attributes`, async () => {
await attributesPage.gotoExistingAttributePage(attribute.id, attribute.name);
await attributesPage.clickDeleteButton();
await attributesPage.dialog.waitFor({
Expand All @@ -212,7 +212,7 @@ for (const attribute of attributesToBeDeleted) {
});
}

test("TC: SALEOR_130 Bulk delete attributes @e2e @attributes", async () => {
test("TC: SALEOR_130 Bulk delete attributes #e2e #attributes", async () => {
await attributesPage.gotoListView();
await attributesPage.searchAndFindRowIndexes("e2e attribute to be bulk deleted");
await attributesPage.clickGridCell(0, 0);
Expand Down
6 changes: 3 additions & 3 deletions playwright/tests/categories.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ let categoriesPage: CategoriesPage;
test.beforeEach(({ page }) => {
categoriesPage = new CategoriesPage(page);
});
test("TC: SALEOR_102 Create basic category @e2e @category", async () => {
test("TC: SALEOR_102 Create basic category #e2e #category", async () => {
await categoriesPage.gotoCategoryListView();
await categoriesPage.waitForDatagridLoaderToDisappear();
await categoriesPage.clickCreateNewCategoryButton();
Expand All @@ -21,7 +21,7 @@ test("TC: SALEOR_102 Create basic category @e2e @category", async () => {
await categoriesPage.clickSaveButton();
await categoriesPage.expectSuccessBanner();
});
test("TC: SALEOR_103 Edit category @e2e @category", async () => {
test("TC: SALEOR_103 Edit category #e2e #category", async () => {
await categoriesPage.gotoExistingCategoriesPage(CATEGORIES.categoryToBeUpdated.id);
await categoriesPage.typeCategoryName("Updated category");
await categoriesPage.typeCategoryDescription("Utils description updated");
Expand All @@ -30,7 +30,7 @@ test("TC: SALEOR_103 Edit category @e2e @category", async () => {
await categoriesPage.expectSuccessBanner();
await expect(categoriesPage.productsGridList).toContainText("beer to be updated");
});
test("TC: SALEOR_104 Bulk delete categories @e2e @category", async () => {
test("TC: SALEOR_104 Bulk delete categories #e2e #category", async () => {
await categoriesPage.gotoCategoryListView();
await categoriesPage.waitForDOMToFullyLoad();
await categoriesPage.checkListRowsBasedOnContainingText(
Expand Down
8 changes: 4 additions & 4 deletions playwright/tests/channels.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ test.beforeEach(({ page }) => {
configurationPage = new ConfigurationPage(page);
channelPage = new ChannelPage(page);
});
test("TC: SALEOR_97 Create basic channel @e2e @channels", async () => {
test("TC: SALEOR_97 Create basic channel #e2e #channels", async () => {
const slugName = new Date().toISOString();

await configurationPage.goToConfigurationView();
Expand All @@ -27,7 +27,7 @@ test("TC: SALEOR_97 Create basic channel @e2e @channels", async () => {
await channelPage.expectSuccessBanner();
});

test("TC: SALEOR_208 Create channel with all settings @e2e @channels", async () => {
test("TC: SALEOR_208 Create channel with all settings #e2e #channels", async () => {
const slugName = new Date().toISOString();

await configurationPage.goToConfigurationView();
Expand All @@ -54,7 +54,7 @@ test("TC: SALEOR_208 Create channel with all settings @e2e @channels", async ()
await expect(channelPage.allowUnpaidOrdersCheckbox).toBeChecked();
});

test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, prio high stock @e2e @channels", async () => {
test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, prio high stock #e2e #channels", async () => {
await channelPage.gotoChannelDetails(CHANNELS.channelToBeEditedSettings.id);
await channelPage.clickTransactionFlowCheckbox();
await channelPage.clickAllowUnpaidOrdersCheckbox();
Expand All @@ -66,7 +66,7 @@ test("TC: SALEOR_98 Edit channel - transaction flow, allow unpaid, authorize, pr
await channelPage.clickSaveButton();
await channelPage.expectSuccessBanner();
});
test("TC: SALEOR_99 Delete channel @e2e @channels", async () => {
test("TC: SALEOR_99 Delete channel #e2e #channels", async () => {
await channelPage.gotoChannelList();
await channelPage.clickDeleteButtonOnRowContainingChannelName(CHANNELS.channelToBeDeleted.name);
await channelPage.deleteChannelDialog.clickDeleteButton();
Expand Down
6 changes: 3 additions & 3 deletions playwright/tests/collections.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ let collectionsPage: CollectionsPage;
test.beforeEach(({ page }) => {
collectionsPage = new CollectionsPage(page);
});
test("TC: SALEOR_112 Create collection @collections @e2e", async () => {
test("TC: SALEOR_112 Create collection #collections #e2e", async () => {
await collectionsPage.gotoCollectionsListView();
await collectionsPage.waitForDOMToFullyLoad();
await collectionsPage.clickCreateCollectionButton();
Expand All @@ -27,7 +27,7 @@ test("TC: SALEOR_112 Create collection @collections @e2e", async () => {
await collectionsPage.clickSaveButton();
await collectionsPage.expectSuccessBanner();
});
test("TC: SALEOR_113 Edit collection: assign product @collections @e2e", async () => {
test("TC: SALEOR_113 Edit collection: assign product #collections #e2e", async () => {
const productToBeAssigned = "Bean Juice";

await collectionsPage.gotoExistingCollectionView(COLLECTIONS.collectionToBeUpdated.id);
Expand All @@ -45,7 +45,7 @@ test("TC: SALEOR_113 Edit collection: assign product @collections @e2e", async (
`Only 1 category should be visible in table`,
).toEqual(1);
});
test("TC: SALEOR_114 Bulk delete collections @collections @e2e", async () => {
test("TC: SALEOR_114 Bulk delete collections #collections #e2e", async () => {
await collectionsPage.gotoCollectionsListView();
await collectionsPage.waitForDOMToFullyLoad();
await collectionsPage.checkListRowsBasedOnContainingText(
Expand Down
22 changes: 11 additions & 11 deletions playwright/tests/customers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test.beforeEach(({ page }) => {
deleteAddressDialog = new DeleteAddressDialog(page);
});

test("TC: SALEOR_199 Create customer @e2e @customer", async () => {
test("TC: SALEOR_199 Create customer #e2e #customer", async () => {
const firstName = faker.name.firstName();
const lastName = faker.name.lastName();
const note = faker.lorem.sentence();
Expand Down Expand Up @@ -56,7 +56,7 @@ test("TC: SALEOR_199 Create customer @e2e @customer", async () => {
await expect(customersPage.customerEmailInput).toHaveValue(email.toLowerCase());
});

test("TC: SALEOR_200 As an admin I should not be able to create customer with duplicated email @e2e @customer", async () => {
test("TC: SALEOR_200 As an admin I should not be able to create customer with duplicated email #e2e #customer", async () => {
const firstName = faker.name.firstName();
const lastName = faker.name.lastName();
const note = faker.lorem.sentence();
Expand All @@ -78,7 +78,7 @@ test("TC: SALEOR_200 As an admin I should not be able to create customer with du
await customersPage.expectErrorBannerMessage("User with this Email already exists.");
});

test("TC: SALEOR_201 Update customer account info @e2e @customer", async () => {
test("TC: SALEOR_201 Update customer account info #e2e #customer", async () => {
const firstName = faker.name.firstName();
const lastName = faker.name.lastName();
const email = faker.internet.email();
Expand All @@ -97,23 +97,23 @@ test("TC: SALEOR_201 Update customer account info @e2e @customer", async () => {
await expect(customersPage.customerEmailInput).toHaveValue(email.toLowerCase());
});

test("TC: SALEOR_202 Deactivate a customer @e2e @customer", async () => {
test("TC: SALEOR_202 Deactivate a customer #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.customerToBeDeactivated.id);
await customersPage.customerActiveCheckbox.click();
await customersPage.saveCustomer();
await customersPage.expectSuccessBanner();
await expect(customersPage.customerActiveCheckbox).not.toBeChecked();
});

test("TC: SALEOR_203 Activate a customer @e2e @customer", async () => {
test("TC: SALEOR_203 Activate a customer #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.customerToBeActivated.id);
await customersPage.customerActiveCheckbox.click();
await customersPage.saveCustomer();
await customersPage.expectSuccessBanner();
await expect(customersPage.customerActiveCheckbox).toBeChecked();
});

test("TC: SALEOR_204 Delete customer from the details page @e2e @customer", async () => {
test("TC: SALEOR_204 Delete customer from the details page #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.deleteCustomer.id);
await customersPage.deleteCustomer();
await customersPage.deleteDialog.clickDeleteButton();
Expand All @@ -123,7 +123,7 @@ test("TC: SALEOR_204 Delete customer from the details page @e2e @customer", asyn
await expect(customersPage.emptyDataGridListView).toBeVisible();
});

test("TC: SALEOR_205 Bulk delete customers @e2e @customer", async () => {
test("TC: SALEOR_205 Bulk delete customers #e2e #customer", async () => {
const customersToBeBulkDeleted = CUSTOMERS.customersToBeBulkDeleted.names;

await customersPage.goToCustomersListView();
Expand All @@ -139,7 +139,7 @@ test("TC: SALEOR_205 Bulk delete customers @e2e @customer", async () => {
await expect(customersPage.emptyDataGridListView).toBeVisible();
});

test("TC: SALEOR_206 As an admin I want to add address to the customer and set it as default shipping @e2e @customer", async () => {
test("TC: SALEOR_206 As an admin I want to add address to the customer and set it as default shipping #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
await addressesListPage.clickManageAddresses();
await addressesListPage.clickAddAddressButton();
Expand Down Expand Up @@ -167,7 +167,7 @@ test("TC: SALEOR_206 As an admin I want to add address to the customer and set i
);
});

test("TC: SALEOR_209 As an admin I want to update customer's address and set it as default billing @e2e @customer", async () => {
test("TC: SALEOR_209 As an admin I want to update customer's address and set it as default billing #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
await addressesListPage.clickManageAddresses();
await addressesListPage.clickShowMoreMenu(CUSTOMERS.editCustomer.initialShippingAddress.lastName);
Expand Down Expand Up @@ -198,7 +198,7 @@ test("TC: SALEOR_209 As an admin I want to update customer's address and set it
);
});

test("TC: SALEOR_210 Delete customer's address @e2e @customer", async () => {
test("TC: SALEOR_210 Delete customer's address #e2e #customer", async () => {
await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
await addressesListPage.clickManageAddresses();
await addressesListPage.clickShowMoreMenu(CUSTOMERS.editCustomer.initialBillingAddress.lastName);
Expand All @@ -211,7 +211,7 @@ test("TC: SALEOR_210 Delete customer's address @e2e @customer", async () => {
).not.toBeVisible();
});

test("TC: SALEOR_207 Issue a new gift card for the customer @e2e @customer", async () => {
test("TC: SALEOR_207 Issue a new gift card for the customer #e2e #customer", async () => {
const amount = faker.datatype.number(1000).toPrecision(2).toString();

await customersPage.gotoCustomerDetailsPage(CUSTOMERS.editCustomer.id);
Expand Down
Loading
Loading