-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y24-213 - Removed default_includes
from v2 API Resources
#4635
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4635 +/- ##
===========================================
- Coverage 89.42% 89.41% -0.02%
===========================================
Files 1406 1406
Lines 30298 30249 -49
===========================================
- Hits 27095 27048 -47
+ Misses 3203 3201 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. We need to make sure that the JSONAPI responses haven't been affected by removing this. How do we test it? Is it through the integration suite or do we plan to manually test the endpoints pertaining to these resources?
Just finished testing, there's one response that has changed, but it's very insignificant. I can give some extra info, but it was just one tag group where the order of the tags was slightly changed because of duplicate indexes. It's hard to tell if it's a problem with the code or not, because it persists throughout different environments. Aside from that, it should be ready to deploy to UAT. |
Closes #4233
Changes proposed in this pull request
default_includes
because it is no longer required.Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main
]- Check story numbers included
- Check for debug code
- Check version