-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move build matrix to .travis.yml and reinstate scala-native support #174
Conversation
This comment has been minimized.
This comment has been minimized.
This does the same thing as scala-xml#223 but for parser-combinators: * the matrix build is moved to .travis.yml, with * jdk 6, 8 and 11 * scala 2.11.12, 2.12.7 and 2.13.0-M5 * JVM, JS 0.6.25 (and JS 1.0.0-M5 eventually) * a few combinations are disabled when not supported or superfluous * re-publishing is done by adding a commit above a tag with the version change and pushing a new tag * ScalaVersionByJvm is not used, crossScalaVersion is enough This should make adding back scala-native support very easy.
It was reverted in scala#135 because of build problems, but this is very easy to add now: we add a single 'jdk8 + scala 2.11.12' job to the build matrix, and also restrict publishing to those versions to be sure. Locally, the native subproject can be run with any jdk > 6 and works normally. fixes scala#141.
f1e2966
to
18b0d45
Compare
We have been using this in scala-xml. There was something nice about |
Isn't that what |
You're right I mischaracterized it. The release-combo does help with the Java and Scala version combination, I guess the problem is that we have js and native targets (well, scala-xml doesn't have native, but I guess you do). |
In this case it should work out. What I liked about |
Another idea I had was to remove the
It's tedious, but all the versions, and whether to publish, are all neatly listed in the same place. |
I also liked the readability of the sbt magic. It's much better than a wall of shell scripting and YAML. I was sorry to see it go. |
perhaps not the last word on this, but let's try it this way for a while... |
This does the same thing as scala/scala-xml#223 but for parser-combinators:
change and pushing a new tag
It was reverted in #135 because of build problems, but this is very easy
to add now: we add a single 'jdk8 + scala 2.11.12' job to the build
matrix, and also restrict publishing to those versions to be sure.
Locally, the native subproject can be run with any jdk > 6 and works
normally.
fixes #141.