Skip to content

Fix dark mode coloration of command bar, X symbol and command keys.#334

Merged
andrewtavis merged 2 commits intoscribe-org:mainfrom
janiceferns02:bugfix/dark_mode_coloration_command_bar
Mar 19, 2025
Merged

Fix dark mode coloration of command bar, X symbol and command keys.#334
andrewtavis merged 2 commits intoscribe-org:mainfrom
janiceferns02:bugfix/dark_mode_coloration_command_bar

Conversation

@janiceferns02
Copy link
Contributor

Contributor checklist


Description

Fix command key color inconsistency with Scribe key in dark mode. Now command keys color matches with the scribe key in both light and dark mode. Also fixed the X icon to cancel the command and the command bar color in dark mode. Tested by switching the dark/light modes in app. Also tested by switching the device's theme on Samsung A34 5G.

Related issue

@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Mar 15, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me now @janiceferns02. If you would like you could change the command bar text color accordingly to the background change. It would be a minor change within the function you have just modified.

@andrewtavis
Copy link
Member

Thanks for the review, @angrezichatterbox! Happy to bring this in after the requested change 😊

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything look fine to me @janiceferns02. It is ready to be merged :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great to me as well, @janiceferns02! Really appreciate the dedication to the project you've been showing! Looking forward to the next issue we get to work on with you 😊

@andrewtavis andrewtavis merged commit 8247a79 into scribe-org:main Mar 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants