Fix dark mode coloration of command bar, X symbol and command keys.#334
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Everything looks good to me now @janiceferns02. If you would like you could change the command bar text color accordingly to the background change. It would be a minor change within the function you have just modified.
|
Thanks for the review, @angrezichatterbox! Happy to bring this in after the requested change 😊 |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Everything look fine to me @janiceferns02. It is ready to be merged :)
andrewtavis
left a comment
There was a problem hiding this comment.
Looking great to me as well, @janiceferns02! Really appreciate the dedication to the project you've been showing! Looking forward to the next issue we get to work on with you 😊
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Fix command key color inconsistency with Scribe key in dark mode. Now command keys color matches with the scribe key in both light and dark mode. Also fixed the X icon to cancel the command and the command bar color in dark mode. Tested by switching the dark/light modes in app. Also tested by switching the device's theme on Samsung A34 5G.
Related issue